From: Greg Kroah-Hartman Date: Wed, 9 Nov 2016 10:09:29 +0000 (+0100) Subject: remove queue-4.8/scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough... X-Git-Tag: v4.4.31~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=25ef119e9c635c1ca39662b368aa7150f2f636e1;p=thirdparty%2Fkernel%2Fstable-queue.git remove queue-4.8/scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough-devices.patch as it is broken --- diff --git a/queue-4.8/scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough-devices.patch b/queue-4.8/scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough-devices.patch deleted file mode 100644 index 238fbcefffa..00000000000 --- a/queue-4.8/scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough-devices.patch +++ /dev/null @@ -1,55 +0,0 @@ -From 1e793f6fc0db920400574211c48f9157a37e3945 Mon Sep 17 00:00:00 2001 -From: Kashyap Desai -Date: Fri, 21 Oct 2016 06:33:32 -0700 -Subject: scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices - -From: Kashyap Desai - -commit 1e793f6fc0db920400574211c48f9157a37e3945 upstream. - -Commit 02b01e010afe ("megaraid_sas: return sync cache call with -success") modified the driver to successfully complete SYNCHRONIZE_CACHE -commands without passing them to the controller. Disk drive caches are -only explicitly managed by controller firmware when operating in RAID -mode. So this commit effectively disabled writeback cache flushing for -any drives used in JBOD mode, leading to data integrity failures. - -[mkp: clarified patch description] - -Fixes: 02b01e010afeeb49328d35650d70721d2ca3fd59 -Signed-off-by: Kashyap Desai -Signed-off-by: Sumit Saxena -Reviewed-by: Tomas Henzl -Reviewed-by: Hannes Reinecke -Reviewed-by: Ewan D. Milne -Signed-off-by: Martin K. Petersen -Signed-off-by: Greg Kroah-Hartman - ---- - drivers/scsi/megaraid/megaraid_sas_base.c | 13 +++++-------- - 1 file changed, 5 insertions(+), 8 deletions(-) - ---- a/drivers/scsi/megaraid/megaraid_sas_base.c -+++ b/drivers/scsi/megaraid/megaraid_sas_base.c -@@ -1713,16 +1713,13 @@ megasas_queue_command(struct Scsi_Host * - goto out_done; - } - -- switch (scmd->cmnd[0]) { -- case SYNCHRONIZE_CACHE: -- /* -- * FW takes care of flush cache on its own -- * No need to send it down -- */ -+ /* -+ * FW takes care of flush cache on its own for Virtual Disk. -+ * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. -+ */ -+ if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { - scmd->result = DID_OK << 16; - goto out_done; -- default: -- break; - } - - return instance->instancet->build_and_issue_cmd(instance, scmd); diff --git a/queue-4.8/series b/queue-4.8/series index fcfefb529f3..3f46212f973 100644 --- a/queue-4.8/series +++ b/queue-4.8/series @@ -94,7 +94,6 @@ firewire-net-fix-fragmented-datagram_size-off-by-one.patch mac80211-discard-multicast-and-4-addr-a-msdus.patch revert-ath9k_hw-implement-temperature-compensation-support-for-ar9003.patch ath10k-cache-calibration-data-when-the-core-is-stopped.patch -scsi-megaraid_sas-fix-data-integrity-failure-for-jbod-passthrough-devices.patch scsi-scsi_debug-fix-memory-leak-if-lbp-enabled-and-module-is-unloaded.patch scsi-arcmsr-send-synchronize_cache-command-to-firmware.patch mmc-dw_mmc-pltfm-fix-the-potential-null-pointer-dereference.patch