From: Andreas Schneider <asn@samba.org>
Date: Thu, 7 Aug 2025 11:48:26 +0000 (+0200)
Subject: s3:utils: Keep password secret in ntlm_auth get_password()
X-Git-Tag: samba-4.23.0rc3~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2629f19dbe5b7b2e133d20ac303d20a2d65b80d9;p=thirdparty%2Fsamba.git

s3:utils: Keep password secret in ntlm_auth get_password()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15893

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit f86739e3abd63ba0b7ba632d796968fec9fa2f8f)
---

diff --git a/source3/utils/ntlm_auth.c b/source3/utils/ntlm_auth.c
index d5ae7c85b22..a424990baa8 100644
--- a/source3/utils/ntlm_auth.c
+++ b/source3/utils/ntlm_auth.c
@@ -254,6 +254,7 @@ static const char *get_password(struct cli_credentials *credentials)
 
 	manage_squid_request(NUM_HELPER_MODES /* bogus */, NULL, state, manage_gensec_get_pw_request, (void **)&password);
 	talloc_steal(credentials, password);
+	talloc_keep_secret(password);
 	TALLOC_FREE(frame);
 	return password;
 }