From: Nguyễn Thái Ngọc Duy Date: Sun, 27 Dec 2015 01:54:34 +0000 (+0700) Subject: dir.c: clean the entire struct in clear_exclude_list() X-Git-Tag: v2.7.1~27^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2653a8c6fa0466828061a3132421cf13a5d6d924;p=thirdparty%2Fgit.git dir.c: clean the entire struct in clear_exclude_list() Make sure "el" can be reuseable again. The problem was el->alloc is not cleared and may cause segfaults next time because add_exclude() thinks el->excludes (being NULL) has enough space. Just clear the entire struct to be safe. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- diff --git a/dir.c b/dir.c index 3f7a0256b6..736ff2ac11 100644 --- a/dir.c +++ b/dir.c @@ -501,9 +501,7 @@ void clear_exclude_list(struct exclude_list *el) free(el->excludes); free(el->filebuf); - el->nr = 0; - el->excludes = NULL; - el->filebuf = NULL; + memset(el, 0, sizeof(*el)); } static void trim_trailing_spaces(char *buf)