From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 5 Dec 2024 16:18:45 +0000 (+0100)
Subject: qga: Don't access global variable in run_agent_once()
X-Git-Tag: v10.0.0-rc0~113^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2657a92b5479c8705b128ed1e55feb8960ed498a;p=thirdparty%2Fqemu.git

qga: Don't access global variable in run_agent_once()

The run_agent_once() function is already given GAState via an
argument. There's no need to access the global ga_state variable
which points to the argument anyways (thanks to
initialize_agent()). Worse, some parts of the function use the
argument and the other use the global variable.  Stick with the
function argument.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/r/8ae7f5d5032b14a5b956fe8aaf47bae5ca401699.1733414906.git.mprivozn@redhat.com
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---

diff --git a/qga/main.c b/qga/main.c
index 50186760bf0..4a695235f01 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -1519,7 +1519,7 @@ static int run_agent_once(GAState *s)
         return EXIT_FAILURE;
     }
 
-    g_main_loop_run(ga_state->main_loop);
+    g_main_loop_run(s->main_loop);
 
     if (s->channel) {
         ga_channel_free(s->channel);