From: SZEDER Gábor Date: Tue, 13 Aug 2019 12:26:46 +0000 (+0200) Subject: completion: use 'sort -u' to deduplicate config variable names X-Git-Tag: v2.24.0-rc0~134^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2675ea1cc0f;p=thirdparty%2Fgit.git completion: use 'sort -u' to deduplicate config variable names The completion script runs the classic '| sort | uniq' pipeline to deduplicate the output of 'git help --config-for-completion'. 'sort -u' does the same, but uses one less external process and pipeline stage. Not a bit win, as it's only run once as the list of supported configuration variables is initialized, but at least it sets a better example for others to follow. Signed-off-by: SZEDER Gábor Signed-off-by: Junio C Hamano --- diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index f89324d84f..b51cb31ea1 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2225,7 +2225,7 @@ __git_config_vars= __git_compute_config_vars () { test -n "$__git_config_vars" || - __git_config_vars="$(git help --config-for-completion | sort | uniq)" + __git_config_vars="$(git help --config-for-completion | sort -u)" } _git_config ()