From: Vlad Buslov <vladbu@mellanox.com>
Date: Tue, 26 Feb 2019 15:34:40 +0000 (+0200)
Subject: net: sched: fix typo in walker_check_empty()
X-Git-Tag: v5.1-rc1~178^2~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=268a351d4a77b50a59094cb4592f851880fe8518;p=thirdparty%2Flinux.git

net: sched: fix typo in walker_check_empty()

Function walker_check_empty() incorrectly verifies that tp pointer is not
NULL, instead of actual filter pointer. Fix conditional to check the right
pointer. Adjust filter pointer naming accordingly to other cls API
functions.

Fixes: 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reported-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index befc06f658dff..478095d50f95b 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -238,10 +238,10 @@ static void tcf_proto_put(struct tcf_proto *tp, bool rtnl_held,
 		tcf_proto_destroy(tp, rtnl_held, extack);
 }
 
-static int walker_check_empty(struct tcf_proto *tp, void *d,
+static int walker_check_empty(struct tcf_proto *tp, void *fh,
 			      struct tcf_walker *arg)
 {
-	if (tp) {
+	if (fh) {
 		arg->nonempty = true;
 		return -1;
 	}