From: Andrew Goodbody Date: Wed, 6 Aug 2025 15:47:46 +0000 (+0100) Subject: phy: keystone-usb: Do not negate return code X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=26d9bd1ccd6b344d1cc9ddb3d50981b106fed3b8;p=thirdparty%2Fu-boot.git phy: keystone-usb: Do not negate return code In keystone_usb_init the return code from psc_enable_module should be returned as is rather than being negated. This issue was found by Smatch. Signed-off-by: Andrew Goodbody --- diff --git a/drivers/phy/keystone-usb-phy.c b/drivers/phy/keystone-usb-phy.c index cfc15203d63..460efbe768d 100644 --- a/drivers/phy/keystone-usb-phy.c +++ b/drivers/phy/keystone-usb-phy.c @@ -41,7 +41,7 @@ static int keystone_usb_init(struct phy *phy) rc = psc_enable_module(keystone->psc_domain); if (rc) { debug("Cannot enable USB module"); - return -rc; + return rc; } mdelay(10);