From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Mon, 4 Aug 2025 16:03:58 +0000 (+0100)
Subject: net: fm: NULL check dev before dereference
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=270798a4209aeb23fce72ebf10e62630f474e431;p=thirdparty%2Fu-boot.git

net: fm: NULL check dev before dereference

In fm_eth_bind there is a dereference of dev before it is NULL checked.
Add a NULL check before the first dereference and remove a later NULL
check that is now redundant.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c
index c83b789693a..f0e7c0eca42 100644
--- a/drivers/net/fm/eth.c
+++ b/drivers/net/fm/eth.c
@@ -727,12 +727,15 @@ static int fm_eth_bind(struct udevice *dev)
 	char mac_name[11];
 	u32 fm, num;
 
+	if (!dev)
+		return -EINVAL;
+
 	if (ofnode_read_u32(ofnode_get_parent(dev_ofnode(dev)), "cell-index", &fm)) {
 		printf("FMan node property cell-index missing\n");
 		return -EINVAL;
 	}
 
-	if (dev && dev_read_u32(dev, "cell-index", &num)) {
+	if (dev_read_u32(dev, "cell-index", &num)) {
 		printf("FMan MAC node property cell-index missing\n");
 		return -EINVAL;
 	}