From: Karel Zak <kzak@redhat.com>
Date: Mon, 17 Feb 2014 12:22:30 +0000 (+0100)
Subject: su: don't use kill(0, ...) when propagate signal
X-Git-Tag: v2.25-rc1~596
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=270ab78a0c84a0d580d3dfa257813abbba385687;p=thirdparty%2Futil-linux.git

su: don't use kill(0, ...) when propagate signal

The current code uses kill(0, caught_signal) after regular
signal cleanup and before exit (all just to make shells happy).

Unfortunately, kill(0, ...) is a bad idea. It seems better to use
kill(getpid(), ...) otherwise we kill our parent process too.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1063887
Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 7fd2792fd6..2766a6033d 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -415,7 +415,7 @@ create_watching_parent (void)
           caught_signal = SIGKILL;
           break;
       }
-      kill(0, caught_signal);
+      kill(getpid(), caught_signal);
     }
   exit (status);
 }