From: Greg Kroah-Hartman Date: Thu, 22 May 2025 10:57:26 +0000 (+0200) Subject: spi: gpio: fix const issue in spi_to_spi_gpio() X-Git-Tag: v6.16-rc1~166^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2712a7d362904d0c4283ae91fac8cea6ecd6f9c2;p=thirdparty%2Flinux.git spi: gpio: fix const issue in spi_to_spi_gpio() While the struct spi_device * passed into spi_to_spi_gpio() is a const one, the struct spi_bitbang * that is retrieved from the controller field in the spi_device is NOT a const pointer, as it is coming from the spi_controller_get_devdata() call, and then passed to container_of() which would strip off the const attribute for no good reason (i.e. if a const pointer is passed to container_of() it still is const coming out). Fix this all up by properly declaring the struct spi_bitbang * as not const. Cc: Mark Brown Signed-off-by: Greg Kroah-Hartman Link: https://patch.msgid.link/2025052225-scallion-ritzy-dbbd@gregkh Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c index 405deb6677c17..ea5f1b10b79e5 100644 --- a/drivers/spi/spi-gpio.c +++ b/drivers/spi/spi-gpio.c @@ -46,7 +46,7 @@ struct spi_gpio { static inline struct spi_gpio *__pure spi_to_spi_gpio(const struct spi_device *spi) { - const struct spi_bitbang *bang; + struct spi_bitbang *bang; struct spi_gpio *spi_gpio; bang = spi_controller_get_devdata(spi->controller);