From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Wed, 5 Oct 2016 22:42:54 +0000 (-0600)
Subject: Do not leak serialized metadata when updating rock-stored headers.
X-Git-Tag: SQUID_4_0_15~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27534aa04f9b5c494bccc1d2a378190c3d44512e;p=thirdparty%2Fsquid.git

Do not leak serialized metadata when updating rock-stored headers.

I added this valgrind-exposed regression in r14584 (Bug 7 fix).
---

diff --git a/src/fs/rock/RockHeaderUpdater.cc b/src/fs/rock/RockHeaderUpdater.cc
index caf5fc691e..9a8db4bf26 100644
--- a/src/fs/rock/RockHeaderUpdater.cc
+++ b/src/fs/rock/RockHeaderUpdater.cc
@@ -184,6 +184,7 @@ Rock::HeaderUpdater::startWriting()
         Must(freshSwapHeader);
         writer->write(freshSwapHeader, freshSwapHeaderSize, 0, nullptr);
         offset += freshSwapHeaderSize;
+        xfree(freshSwapHeader);
     }
 
     {