From: Tom de Vries Date: Thu, 20 Mar 2025 11:37:04 +0000 (+0100) Subject: [gdb/testsuite] Add missing returns in gdb.threads/infcall-from-bp-cond-simple.c X-Git-Tag: binutils-2_45~1089 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2774eeb9e2acb7d5a7967c55d8365fc1278244a4;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite] Add missing returns in gdb.threads/infcall-from-bp-cond-simple.c While investigating PR32785 I noticed a missing return statement in worker_func, and compiling with -Wreturn-type showed another in function_that_segfaults: ... $ gcc gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c -Wreturn-type infcall-from-bp-cond-simple.c: In function ‘function_that_segfaults’: infcall-from-bp-cond-simple.c:46:1: warning: \ control reaches end of non-void function [-Wreturn-type] 46 | } | ^ infcall-from-bp-cond-simple.c: In function ‘worker_func’: infcall-from-bp-cond-simple.c:58:1: warning: \ control reaches end of non-void function [-Wreturn-type] 58 | } | ^ ... Fix these by adding the missing returns. --- diff --git a/gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c b/gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c index 2e23f1229c5..d0707cd2e9f 100644 --- a/gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c +++ b/gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c @@ -43,6 +43,7 @@ function_that_segfaults () { int *p = 0; *p = 1; /* Segfault happens here. */ + return 0; } int @@ -55,6 +56,7 @@ void * worker_func (void *arg) { int a = 42; /* Breakpoint here. */ + return NULL; } void