From: Ilan Peer Date: Wed, 3 Apr 2019 12:16:14 +0000 (+0300) Subject: crypto: Fix unreachable code in tls_prf_sha1_md5() X-Git-Tag: hostap_2_8~138 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=277fa92b376726dbe4bdc765ed2e084d8050ee1e;p=thirdparty%2Fhostap.git crypto: Fix unreachable code in tls_prf_sha1_md5() While commit 1c156e783d35 ("Fixed tls_prf() to handle keys with odd length") added support for keys with odd length, the function never reached this code as the function would return earlier in case the key length was odd. Fix this by removing the first check for the key length. Signed-off-by: Ilan Peer --- diff --git a/src/crypto/sha1-tlsprf.c b/src/crypto/sha1-tlsprf.c index f9bc0ebf6..a11649a93 100644 --- a/src/crypto/sha1-tlsprf.c +++ b/src/crypto/sha1-tlsprf.c @@ -40,9 +40,6 @@ int tls_prf_sha1_md5(const u8 *secret, size_t secret_len, const char *label, const unsigned char *SHA1_addr[3]; size_t SHA1_len[3]; - if (secret_len & 1) - return -1; - MD5_addr[0] = A_MD5; MD5_len[0] = MD5_MAC_LEN; MD5_addr[1] = (unsigned char *) label;