From: dan <Dan Kennedy>
Date: Thu, 8 Dec 2022 21:05:33 +0000 (+0000)
Subject: Support ".scanstats est" to enable including planner estimates in query profiles.
X-Git-Tag: version-3.41.0~288
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2797ac028cb43a89cef2bd308a3422d334318990;p=thirdparty%2Fsqlite.git

Support ".scanstats est" to enable including planner estimates in query profiles.

FossilOrigin-Name: 0fe71287c953bd813a34ba383f5debd4d1fc8bf3c74e1e27adacec0d6e207ded
---

diff --git a/manifest b/manifest
index 6cc38aedce..571bb34a72 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Further\sdocs\sand\sminor\scleanups\sin\sthe\sJS\svirtual\stable\shelper.
-D 2022-12-08T18:18:37.994
+C Support\s".scanstats\sest"\sto\senable\sincluding\splanner\sestimates\sin\squery\sprofiles.
+D 2022-12-08T21:05:33.635
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -646,7 +646,7 @@ F src/random.c 606b00941a1d7dd09c381d3279a058d771f406c5213c9932bbd93d5587be4b9c
 F src/resolve.c efea4e5fbecfd6d0a9071b0be0d952620991673391b6ffaaf4c277b0bb674633
 F src/rowset.c ba9515a922af32abe1f7d39406b9d35730ed65efab9443dc5702693b60854c92
 F src/select.c 56162cde2f71314826f831618eae853205628080afa25cd90faef7a9b761dee4
-F src/shell.c.in bcf8552c82f2c84650e39a6d638373569c2035942c0497b83eef197169e0305a
+F src/shell.c.in 8d9dc02dd03f8fc93f3e3cdb17d8d16e8ddb985dddad213985c08186900a3ebb
 F src/sqlite.h.in d79b45e95a211376ee7911fe5edd2a8a7f85b14c2383248945bbd1f3203153de
 F src/sqlite3.rc 5121c9e10c3964d5755191c80dd1180c122fc3a8
 F src/sqlite3ext.h c4b9fa7a7e2bcdf850cfeb4b8a91d5ec47b7a00033bc996fd2ee96cbf2741f5f
@@ -2067,8 +2067,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 54c7ad7e08bdb87579398ade366605bfa2e2538a94aabcc6e4cda8e173649760
-R 4c50a667470c9bbb57a953933f0b79e2
-U stephan
-Z df7927342245d4323b165b2786a2dc10
+P c31e7488ac1a6b957782b72bd026b1f0590637b631e44a1fdf1dedeb5c587819
+R 196dc006e445c45f419d571c91fca0d9
+U dan
+Z b6f422040c9b3b9b458fdf6204a182d0
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 980af730dd..6ab5406dfa 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-c31e7488ac1a6b957782b72bd026b1f0590637b631e44a1fdf1dedeb5c587819
\ No newline at end of file
+0fe71287c953bd813a34ba383f5debd4d1fc8bf3c74e1e27adacec0d6e207ded
\ No newline at end of file
diff --git a/src/shell.c.in b/src/shell.c.in
index e4b054f450..131a82d2a5 100644
--- a/src/shell.c.in
+++ b/src/shell.c.in
@@ -3125,6 +3125,7 @@ static void display_scanstats(
     int iId = 0;
     int iPid = 0;
     const char *z = 0;
+    const char *zName = 0;
     char *zText = 0;
     double rEst = 0.0;
 
@@ -3137,6 +3138,7 @@ static void display_scanstats(
     sqlite3_stmt_scanstatus_v2(p, ii, SQLITE_SCANSTAT_NCYCLE,f,(void*)&nCycle);
     sqlite3_stmt_scanstatus_v2(p, ii, SQLITE_SCANSTAT_SELECTID,f,(void*)&iId);
     sqlite3_stmt_scanstatus_v2(p, ii, SQLITE_SCANSTAT_PARENTID,f,(void*)&iPid);
+    sqlite3_stmt_scanstatus_v2(p, ii, SQLITE_SCANSTAT_NAME,f,(void*)&zName);
 
     zText = sqlite3_mprintf("%s", z);
     if( nCycle>=0 || nLoop>=0 || nRow>=0 ){
@@ -3153,6 +3155,11 @@ static void display_scanstats(
         z = sqlite3_mprintf("%z%srows=%lld", z, z ? " " : "", nRow);
       }
 
+      if( zName && pArg->scanstatsOn>1 ){
+        double rpl = (double)nRow / (double)nLoop;
+        z = sqlite3_mprintf("%z rpl=%.1f est=%.1f", z, rpl, rEst);
+      }
+
       zText = sqlite3_mprintf(
           "% *z (%z)", -1*(nWidth-scanStatsHeight(p, ii)*3), zText, z
       );
@@ -4678,7 +4685,7 @@ static const char *(azHelp[]) = {
   ".restore ?DB? FILE       Restore content of DB (default \"main\") from FILE",
   ".save ?OPTIONS? FILE     Write database to FILE (an alias for .backup ...)",
 #endif
-  ".scanstats on|off        Turn sqlite3_stmt_scanstatus() metrics on or off",
+  ".scanstats on|off|est    Turn sqlite3_stmt_scanstatus() metrics on or off",
   ".schema ?PATTERN?        Show the CREATE statements matching PATTERN",
   "   Options:",
   "      --indent             Try to pretty-print the schema",
@@ -9707,12 +9714,16 @@ static int do_meta_command(char *zLine, ShellState *p){
 
   if( c=='s' && cli_strncmp(azArg[0], "scanstats", n)==0 ){
     if( nArg==2 ){
-      p->scanstatsOn = (u8)booleanValue(azArg[1]);
+      if( cli_strcmp(azArg[1], "est")==0 ){
+        p->scanstatsOn = 2;
+      }else{
+        p->scanstatsOn = (u8)booleanValue(azArg[1]);
+      }
 #ifndef SQLITE_ENABLE_STMT_SCANSTATUS
       raw_printf(stderr, "Warning: .scanstats not available in this build.\n");
 #endif
     }else{
-      raw_printf(stderr, "Usage: .scanstats on|off\n");
+      raw_printf(stderr, "Usage: .scanstats on|off|est\n");
       rc = 1;
     }
   }else