From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 31 Aug 2021 08:46:06 +0000 (+0200)
Subject: homed: make sure to use right asssesors for GID + access mode
X-Git-Tag: v250-rc1~752^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=279e060e2549183101ebf94e9739b70ed499c4c1;p=thirdparty%2Fsystemd.git

homed: make sure to use right asssesors for GID + access mode

Don't reach directly into the UserRecord struct, but use the right
assessors, so that the "unspecified" case is covered.
---

diff --git a/src/home/homework-cifs.c b/src/home/homework-cifs.c
index 2254eb59cd7..cf3c58431a0 100644
--- a/src/home/homework-cifs.c
+++ b/src/home/homework-cifs.c
@@ -58,8 +58,8 @@ int home_prepare_cifs(
 
                         f = safe_fclose(f);
 
-                        if (asprintf(&options, "credentials=%s,uid=" UID_FMT ",forceuid,gid=" UID_FMT ",forcegid,file_mode=0%3o,dir_mode=0%3o",
-                                     p, h->uid, h->uid, h->access_mode, h->access_mode) < 0)
+                        if (asprintf(&options, "credentials=%s,uid=" UID_FMT ",forceuid,gid=" GID_FMT ",forcegid,file_mode=0%3o,dir_mode=0%3o",
+                                     p, h->uid, user_record_gid(h), user_record_access_mode(h), user_record_access_mode(h)) < 0)
                                 return log_oom();
 
                         r = safe_fork("(mount)", FORK_RESET_SIGNALS|FORK_RLIMIT_NOFILE_SAFE|FORK_DEATHSIG|FORK_LOG|FORK_STDOUT_TO_STDERR, &mount_pid);