From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 15 Sep 2019 15:51:57 +0000 (-0400)
Subject: Fix bogus sizeof calculations.
X-Git-Tag: REL_12_RC1~35
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27bc87985c4135f27bdcddd905baad3b62a3f03a;p=thirdparty%2Fpostgresql.git

Fix bogus sizeof calculations.

Noted by Coverity.  Typo in 27cc7cd2b, so back-patch to v12
as that was.
---

diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index d616ba361f5..1438685536f 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -2917,7 +2917,7 @@ EvalPlanQualStart(EPQState *epqstate, Plan *planTree)
 	{
 		Assert(epqstate->relsubs_done != NULL);
 		memset(epqstate->relsubs_rowmark, 0,
-			   sizeof(rtsize * sizeof(ExecAuxRowMark *)));
+			   rtsize * sizeof(ExecAuxRowMark *));
 		memset(epqstate->relsubs_done, 0,
 			   rtsize * sizeof(bool));
 	}
@@ -2971,7 +2971,7 @@ EvalPlanQualEnd(EPQState *epqstate)
 	if (epqstate->tuple_table != NIL)
 	{
 		memset(epqstate->relsubs_slot, 0,
-			   sizeof(rtsize * sizeof(TupleTableSlot *)));
+			   rtsize * sizeof(TupleTableSlot *));
 		ExecResetTupleTable(epqstate->tuple_table, true);
 		epqstate->tuple_table = NIL;
 	}