From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Tue, 26 Oct 2021 16:29:54 +0000 (+0300)
Subject: device property: Drop redundant NULL checks
X-Git-Tag: v5.16-rc1~118^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27e0bcd02990f7291adb0f111e300f06c495d509;p=thirdparty%2Fkernel%2Flinux.git

device property: Drop redundant NULL checks

In cases when functions are called via fwnode operations,
we already know that this is software node we are dealing
with, hence no need to check if it's NULL, it can't be,

Reported-by: YE Chengfeng <cyeaa@connect.ust.hk>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211026162954.89811-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index c46f6a8e14d23..4debcea4fb12d 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode)
 {
 	const struct swnode *swnode = to_swnode(fwnode);
 
-	if (!swnode)
-		return "(null)";
-
 	return kobject_name(&swnode->kobj);
 }
 
@@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
 	int error;
 	int i;
 
-	if (!swnode)
-		return -ENOENT;
-
 	prop = property_entry_get(swnode->node->properties, propname);
 	if (!prop)
 		return -ENOENT;