From: Patrick Steinhardt Date: Tue, 28 Jan 2025 08:41:28 +0000 (+0100) Subject: git-compat-util: drop `z_const` define X-Git-Tag: v2.49.0-rc0~53^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27e8960037289dc10e6f659b424c66bfb07146b5;p=thirdparty%2Fgit.git git-compat-util: drop `z_const` define Before including we explicitly define `z_const` to an empty value. This has the effect that the `z_const` macro in "zconf.h" itself will remain empty instead of being defined as `const`, which effectively adapts a couple of APIs so that their parameters are not marked as being constants. It is dubious though whether this is something we actually want: not marking a parameter as a constant doesn't make it any less constant than it was. The define was added via 07564773c2 (compat: auto-detect if zlib has uncompress2(), 2022-01-24), where it was seemingly carried over from our internal compatibility shim for `uncompress2()` that was removed in the preceding commit. The commit message doesn't mention why we carry over the define and make it public, either, and I cannot think of any reason for why we would want to have it. Drop the define. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- diff --git a/git-compat-util.h b/git-compat-util.h index d50f487c00..c4b4b372b4 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -1537,7 +1537,6 @@ int cmd_main(int, const char **); int common_exit(const char *file, int line, int code); #define exit(code) exit(common_exit(__FILE__, __LINE__, (code))) -#define z_const #include /*