From: Jakub Jelinek Date: Mon, 24 Feb 2025 08:25:34 +0000 (+0100) Subject: openmp: Fix diagnostics typo [PR118993] X-Git-Tag: basepoints/gcc-16~1869 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27ebd2a55cd373542977b21631b6b0919e703733;p=thirdparty%2Fgcc.git openmp: Fix diagnostics typo [PR118993] There is a typo in one of the OpenMP gimplification diagnostics messages. The following patch fixes that and adjusts tests which just copied that message including typo to dg-warning regexps in 2 tests. 2025-02-24 Jakub Jelinek PR middle-end/118993 * gimplify.cc (gimplify_scan_omp_clauses): Fix diagnostics typo, undfined -> undefined. * c-c++-common/gomp/allocate-18.c: Adjust dg-warning regex for diagnostics typo fix. * gfortran.dg/gomp/allocate-clause.f90: Likewise. --- diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc index cc0172cf96e..756cdea173f 100644 --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@ -14007,7 +14007,7 @@ gimplify_scan_omp_clauses (tree *list_p, gimple_seq *pre_p, && (code == OMP_TARGET || code == OMP_TASK || code == OMP_TASKLOOP)) warning_at (OMP_CLAUSE_LOCATION (c), OPT_Wopenmp, "allocator with access trait set to % " - "results in undfined behavior for %qs directive", + "results in undefined behavior for %qs directive", code == OMP_TARGET ? "target" : (code == OMP_TASK ? "task" : "taskloop")); diff --git a/gcc/testsuite/c-c++-common/gomp/allocate-18.c b/gcc/testsuite/c-c++-common/gomp/allocate-18.c index 93c5aca29a7..49dc60fb6f5 100644 --- a/gcc/testsuite/c-c++-common/gomp/allocate-18.c +++ b/gcc/testsuite/c-c++-common/gomp/allocate-18.c @@ -36,16 +36,16 @@ test1 () x[0] = 1; #pragma omp target allocate(omp_thread_mem_alloc: x) firstprivate(x) /* uses_allocators(omp_thread_mem_alloc) */ - /* { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'target' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ + /* { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'target' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ x[0] = 1; #pragma omp taskloop allocate(omp_thread_mem_alloc: x) firstprivate(x) - /* { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ + /* { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ for (int i = 0; i < 5; i++) x[i] = i; #pragma omp parallel master taskloop simd allocate(omp_thread_mem_alloc: x) firstprivate(x) - /* { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ + /* { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ for (int i = 0; i < 5; i++) x[i] = i; @@ -53,7 +53,7 @@ test1 () #pragma omp masked { #pragma omp task allocate(omp_thread_mem_alloc: x) firstprivate(x) - /* { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'task' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ + /* { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'task' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } */ x[0] = 1; } } diff --git a/gcc/testsuite/gfortran.dg/gomp/allocate-clause.f90 b/gcc/testsuite/gfortran.dg/gomp/allocate-clause.f90 index 3548538c3c1..b60bca0a126 100644 --- a/gcc/testsuite/gfortran.dg/gomp/allocate-clause.f90 +++ b/gcc/testsuite/gfortran.dg/gomp/allocate-clause.f90 @@ -34,18 +34,18 @@ subroutine test1 () !$omp end parallel !$omp target allocate(omp_thread_mem_alloc: x) firstprivate(x) ! uses_allocators(omp_thread_mem_alloc) - ! { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'target' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } + ! { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'target' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } x(1) = 1 !$omp end target !$omp taskloop allocate(omp_thread_mem_alloc: x) firstprivate(x) - ! { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } + ! { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } do i = 1, 5 x(i) = i end do !$omp parallel master taskloop simd allocate(omp_thread_mem_alloc: x) firstprivate(x) - ! { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } + ! { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'taskloop' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } do i = 1, 5 x(i) = i end do @@ -53,7 +53,7 @@ subroutine test1 () !$omp parallel !$omp masked !$omp task allocate(omp_thread_mem_alloc: x) firstprivate(x) - ! { dg-warning "allocator with access trait set to 'thread' results in undfined behavior for 'task' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } + ! { dg-warning "allocator with access trait set to 'thread' results in undefined behavior for 'task' directive \\\[-Wopenmp\\\]" "" { target *-*-* } .-1 } x(1) = 1 !$omp end task !$omp end masked