From: Axel Lin Date: Fri, 6 Aug 2010 00:09:14 +0000 (+0800) Subject: regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() X-Git-Tag: v2.6.36-rc1~58^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=27ef7f00c96e45192d5dcc7e4589376f3a2fded3;p=thirdparty%2Fkernel%2Flinux.git regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() We already check count value before calling i2c_smbus_read_byte_data(), no need to check it again. Signed-off-by: Axel Lin Acked-by: Mark Brown Signed-off-by: Liam Girdwood --- diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index 8ae3732eb24bc..5362289c7d69d 100644 --- a/drivers/regulator/lp3971.c +++ b/drivers/regulator/lp3971.c @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, if (count != 1) return -EIO; ret = i2c_smbus_read_byte_data(i2c, reg); - if (ret < 0 || count != 1) + if (ret < 0) return -EIO; *dest = ret;