From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 24 Nov 2015 17:06:28 +0000 (+0100)
Subject: ivshmem: Mark questionable socket type test FIXME
X-Git-Tag: v2.5.0-rc2~10^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2825717c02f5b1367e8e315b222888db00618170;p=thirdparty%2Fqemu.git

ivshmem: Mark questionable socket type test FIXME

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 83d7bd3e5f0..edb22704c7a 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
         memory_region_add_subregion(&s->bar, 0, mr);
         pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
     } else if (s->server_chr != NULL) {
+        /* FIXME do not rely on what chr drivers put into filename */
         if (strncmp(s->server_chr->filename, "unix:", 5)) {
             error_setg(errp, "chardev is not a unix client socket");
             return;