From: Cai Huoqing Date: Wed, 15 Sep 2021 14:57:25 +0000 (+0800) Subject: can: mscan: mpc5xxx_can: Make use of the helper function dev_err_probe() X-Git-Tag: v5.16-rc1~159^2~104^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=28616ed180c37ef110af6c24903a02fb1e0c3623;p=thirdparty%2Fkernel%2Flinux.git can: mscan: mpc5xxx_can: Make use of the helper function dev_err_probe() When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. And using dev_err_probe() can reduce code size, and simplify the code. Link: https://lore.kernel.org/all/20210915145726.7092-1-caihuoqing@baidu.com Signed-off-by: Cai Huoqing Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c index 35892c1efef02..de4ddf79ba9be 100644 --- a/drivers/net/can/mscan/mpc5xxx_can.c +++ b/drivers/net/can/mscan/mpc5xxx_can.c @@ -293,10 +293,8 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev) return -EINVAL; base = of_iomap(np, 0); - if (!base) { - dev_err(&ofdev->dev, "couldn't ioremap\n"); - return err; - } + if (!base) + return dev_err_probe(&ofdev->dev, err, "couldn't ioremap\n"); irq = irq_of_parse_and_map(np, 0); if (!irq) {