From: Michael Tremer <michael.tremer@ipfire.org>
Date: Thu, 4 May 2023 15:20:07 +0000 (+0000)
Subject: cgroups: Fix checks for file descriptors
X-Git-Tag: 0.9.29~165
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2868fb2f2a0d87c6a114afffdbe555eafc50e169;p=people%2Fms%2Fpakfire.git

cgroups: Fix checks for file descriptors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/cgroup.c b/src/libpakfire/cgroup.c
index cc6cce94c..22b6ba83c 100644
--- a/src/libpakfire/cgroup.c
+++ b/src/libpakfire/cgroup.c
@@ -148,7 +148,7 @@ static void pakfire_cgroup_free(struct pakfire_cgroup* cgroup) {
 		pakfire_cgroup_name(cgroup), cgroup);
 
 	// Close the file descriptor
-	if (cgroup->fd)
+	if (cgroup->fd > 0)
 		close(cgroup->fd);
 
 	pakfire_unref(cgroup->pakfire);
@@ -251,7 +251,7 @@ static FILE* pakfire_cgroup_open_file(struct pakfire_cgroup* cgroup,
 		goto ERROR;
 
 ERROR:
-	if (fd)
+	if (fd > 0)
 		close(fd);
 
 	return f;
@@ -637,7 +637,7 @@ int pakfire_cgroup_destroy(struct pakfire_cgroup* cgroup) {
 		return r;
 
 	// Close the file descriptor
-	if (cgroup->fd) {
+	if (cgroup->fd > 0) {
 		close(cgroup->fd);
 		cgroup->fd = 0;
 	}