From: Greg Kroah-Hartman Date: Wed, 19 Aug 2020 12:40:07 +0000 (+0200) Subject: 4.9-stable patches X-Git-Tag: v4.14.194~33 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=286ab15eeed957e7a9bcfd14217785d082047bd9;p=thirdparty%2Fkernel%2Fstable-queue.git 4.9-stable patches added patches: bcache-allocate-meta-data-pages-as-compound-pages.patch ext2-fix-missing-percpu_counter_inc.patch ftrace-setup-correct-ftrace_fl_regs-flags-for-module.patch kprobes-fix-null-pointer-dereference-at-kprobe_ftrace_handler.patch mac80211-fix-misplaced-while-instead-of-if.patch md-raid5-fix-force-reconstruct-write-io-stuck-in-degraded-raid5.patch mips-cpu-0-is-not-hotpluggable.patch net-compat-add-missing-sock-updates-for-scm_rights.patch net-ethernet-stmmac-disable-hardware-multicast-filter.patch net-stmmac-dwmac1000-provide-multicast-filter-fallback.patch ocfs2-change-slot-number-type-s16-to-u16.patch pseries-fix-64-bit-logical-memory-block-panic.patch watchdog-f71808e_wdt-clear-watchdog-timeout-occurred-flag.patch watchdog-f71808e_wdt-indicate-wdiof_cardreset-support-in-watchdog_info.options.patch watchdog-f71808e_wdt-remove-use-of-wrong-watchdog_info-option.patch --- diff --git a/queue-4.9/bcache-allocate-meta-data-pages-as-compound-pages.patch b/queue-4.9/bcache-allocate-meta-data-pages-as-compound-pages.patch new file mode 100644 index 00000000000..ef29bb532ec --- /dev/null +++ b/queue-4.9/bcache-allocate-meta-data-pages-as-compound-pages.patch @@ -0,0 +1,80 @@ +From 5fe48867856367142d91a82f2cbf7a57a24cbb70 Mon Sep 17 00:00:00 2001 +From: Coly Li +Date: Sat, 25 Jul 2020 20:00:16 +0800 +Subject: bcache: allocate meta data pages as compound pages + +From: Coly Li + +commit 5fe48867856367142d91a82f2cbf7a57a24cbb70 upstream. + +There are some meta data of bcache are allocated by multiple pages, +and they are used as bio bv_page for I/Os to the cache device. for +example cache_set->uuids, cache->disk_buckets, journal_write->data, +bset_tree->data. + +For such meta data memory, all the allocated pages should be treated +as a single memory block. Then the memory management and underlying I/O +code can treat them more clearly. + +This patch adds __GFP_COMP flag to all the location allocating >0 order +pages for the above mentioned meta data. Then their pages are treated +as compound pages now. + +Signed-off-by: Coly Li +Cc: stable@vger.kernel.org +Signed-off-by: Jens Axboe +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/md/bcache/bset.c | 2 +- + drivers/md/bcache/btree.c | 2 +- + drivers/md/bcache/journal.c | 4 ++-- + drivers/md/bcache/super.c | 2 +- + 4 files changed, 5 insertions(+), 5 deletions(-) + +--- a/drivers/md/bcache/bset.c ++++ b/drivers/md/bcache/bset.c +@@ -317,7 +317,7 @@ int bch_btree_keys_alloc(struct btree_ke + + b->page_order = page_order; + +- t->data = (void *) __get_free_pages(gfp, b->page_order); ++ t->data = (void *) __get_free_pages(__GFP_COMP|gfp, b->page_order); + if (!t->data) + goto err; + +--- a/drivers/md/bcache/btree.c ++++ b/drivers/md/bcache/btree.c +@@ -790,7 +790,7 @@ int bch_btree_cache_alloc(struct cache_s + mutex_init(&c->verify_lock); + + c->verify_ondisk = (void *) +- __get_free_pages(GFP_KERNEL, ilog2(bucket_pages(c))); ++ __get_free_pages(GFP_KERNEL|__GFP_COMP, ilog2(bucket_pages(c))); + + c->verify_data = mca_bucket_alloc(c, &ZERO_KEY, GFP_KERNEL); + +--- a/drivers/md/bcache/journal.c ++++ b/drivers/md/bcache/journal.c +@@ -839,8 +839,8 @@ int bch_journal_alloc(struct cache_set * + j->w[1].c = c; + + if (!(init_fifo(&j->pin, JOURNAL_PIN, GFP_KERNEL)) || +- !(j->w[0].data = (void *) __get_free_pages(GFP_KERNEL, JSET_BITS)) || +- !(j->w[1].data = (void *) __get_free_pages(GFP_KERNEL, JSET_BITS))) ++ !(j->w[0].data = (void *) __get_free_pages(GFP_KERNEL|__GFP_COMP, JSET_BITS)) || ++ !(j->w[1].data = (void *) __get_free_pages(GFP_KERNEL|__GFP_COMP, JSET_BITS))) + return -ENOMEM; + + return 0; +--- a/drivers/md/bcache/super.c ++++ b/drivers/md/bcache/super.c +@@ -1468,7 +1468,7 @@ void bch_cache_set_unregister(struct cac + } + + #define alloc_bucket_pages(gfp, c) \ +- ((void *) __get_free_pages(__GFP_ZERO|gfp, ilog2(bucket_pages(c)))) ++ ((void *) __get_free_pages(__GFP_ZERO|__GFP_COMP|gfp, ilog2(bucket_pages(c)))) + + struct cache_set *bch_cache_set_alloc(struct cache_sb *sb) + { diff --git a/queue-4.9/ext2-fix-missing-percpu_counter_inc.patch b/queue-4.9/ext2-fix-missing-percpu_counter_inc.patch new file mode 100644 index 00000000000..21d5084dfb1 --- /dev/null +++ b/queue-4.9/ext2-fix-missing-percpu_counter_inc.patch @@ -0,0 +1,46 @@ +From bc2fbaa4d3808aef82dd1064a8e61c16549fe956 Mon Sep 17 00:00:00 2001 +From: Mikulas Patocka +Date: Mon, 20 Apr 2020 16:02:21 -0400 +Subject: ext2: fix missing percpu_counter_inc + +From: Mikulas Patocka + +commit bc2fbaa4d3808aef82dd1064a8e61c16549fe956 upstream. + +sbi->s_freeinodes_counter is only decreased by the ext2 code, it is never +increased. This patch fixes it. + +Note that sbi->s_freeinodes_counter is only used in the algorithm that +tries to find the group for new allocations, so this bug is not easily +visible (the only visibility is that the group finding algorithm selects +inoptinal result). + +Link: https://lore.kernel.org/r/alpine.LRH.2.02.2004201538300.19436@file01.intranet.prod.int.rdu2.redhat.com +Signed-off-by: Mikulas Patocka +Cc: stable@vger.kernel.org +Signed-off-by: Jan Kara +Signed-off-by: Greg Kroah-Hartman + +--- + fs/ext2/ialloc.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/fs/ext2/ialloc.c ++++ b/fs/ext2/ialloc.c +@@ -79,6 +79,7 @@ static void ext2_release_inode(struct su + if (dir) + le16_add_cpu(&desc->bg_used_dirs_count, -1); + spin_unlock(sb_bgl_lock(EXT2_SB(sb), group)); ++ percpu_counter_inc(&EXT2_SB(sb)->s_freeinodes_counter); + if (dir) + percpu_counter_dec(&EXT2_SB(sb)->s_dirs_counter); + mark_buffer_dirty(bh); +@@ -530,7 +531,7 @@ got: + goto fail; + } + +- percpu_counter_add(&sbi->s_freeinodes_counter, -1); ++ percpu_counter_dec(&sbi->s_freeinodes_counter); + if (S_ISDIR(mode)) + percpu_counter_inc(&sbi->s_dirs_counter); + diff --git a/queue-4.9/ftrace-setup-correct-ftrace_fl_regs-flags-for-module.patch b/queue-4.9/ftrace-setup-correct-ftrace_fl_regs-flags-for-module.patch new file mode 100644 index 00000000000..d5aa86682c2 --- /dev/null +++ b/queue-4.9/ftrace-setup-correct-ftrace_fl_regs-flags-for-module.patch @@ -0,0 +1,58 @@ +From 8a224ffb3f52b0027f6b7279854c71a31c48fc97 Mon Sep 17 00:00:00 2001 +From: Chengming Zhou +Date: Wed, 29 Jul 2020 02:05:53 +0800 +Subject: ftrace: Setup correct FTRACE_FL_REGS flags for module + +From: Chengming Zhou + +commit 8a224ffb3f52b0027f6b7279854c71a31c48fc97 upstream. + +When module loaded and enabled, we will use __ftrace_replace_code +for module if any ftrace_ops referenced it found. But we will get +wrong ftrace_addr for module rec in ftrace_get_addr_new, because +rec->flags has not been setup correctly. It can cause the callback +function of a ftrace_ops has FTRACE_OPS_FL_SAVE_REGS to be called +with pt_regs set to NULL. +So setup correct FTRACE_FL_REGS flags for rec when we call +referenced_filters to find ftrace_ops references it. + +Link: https://lkml.kernel.org/r/20200728180554.65203-1-zhouchengming@bytedance.com + +Cc: stable@vger.kernel.org +Fixes: 8c4f3c3fa9681 ("ftrace: Check module functions being traced on reload") +Signed-off-by: Chengming Zhou +Signed-off-by: Muchun Song +Signed-off-by: Steven Rostedt (VMware) +Signed-off-by: Greg Kroah-Hartman + +--- + kernel/trace/ftrace.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +--- a/kernel/trace/ftrace.c ++++ b/kernel/trace/ftrace.c +@@ -4987,8 +4987,11 @@ static int referenced_filters(struct dyn + int cnt = 0; + + for (ops = ftrace_ops_list; ops != &ftrace_list_end; ops = ops->next) { +- if (ops_references_rec(ops, rec)) +- cnt++; ++ if (ops_references_rec(ops, rec)) { ++ cnt++; ++ if (ops->flags & FTRACE_OPS_FL_SAVE_REGS) ++ rec->flags |= FTRACE_FL_REGS; ++ } + } + + return cnt; +@@ -5084,8 +5087,8 @@ void ftrace_module_enable(struct module + if (ftrace_start_up) + cnt += referenced_filters(rec); + +- /* This clears FTRACE_FL_DISABLED */ +- rec->flags = cnt; ++ rec->flags &= ~FTRACE_FL_DISABLED; ++ rec->flags += cnt; + + if (ftrace_start_up && cnt) { + int failed = __ftrace_replace_code(rec, 1); diff --git a/queue-4.9/kprobes-fix-null-pointer-dereference-at-kprobe_ftrace_handler.patch b/queue-4.9/kprobes-fix-null-pointer-dereference-at-kprobe_ftrace_handler.patch new file mode 100644 index 00000000000..3b17d8bcefe --- /dev/null +++ b/queue-4.9/kprobes-fix-null-pointer-dereference-at-kprobe_ftrace_handler.patch @@ -0,0 +1,94 @@ +From 0cb2f1372baa60af8456388a574af6133edd7d80 Mon Sep 17 00:00:00 2001 +From: Muchun Song +Date: Tue, 28 Jul 2020 14:45:36 +0800 +Subject: kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler + +From: Muchun Song + +commit 0cb2f1372baa60af8456388a574af6133edd7d80 upstream. + +We found a case of kernel panic on our server. The stack trace is as +follows(omit some irrelevant information): + + BUG: kernel NULL pointer dereference, address: 0000000000000080 + RIP: 0010:kprobe_ftrace_handler+0x5e/0xe0 + RSP: 0018:ffffb512c6550998 EFLAGS: 00010282 + RAX: 0000000000000000 RBX: ffff8e9d16eea018 RCX: 0000000000000000 + RDX: ffffffffbe1179c0 RSI: ffffffffc0535564 RDI: ffffffffc0534ec0 + RBP: ffffffffc0534ec1 R08: ffff8e9d1bbb0f00 R09: 0000000000000004 + R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 + R13: ffff8e9d1f797060 R14: 000000000000bacc R15: ffff8e9ce13eca00 + CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 + CR2: 0000000000000080 CR3: 00000008453d0005 CR4: 00000000003606e0 + DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 + DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 + Call Trace: + + ftrace_ops_assist_func+0x56/0xe0 + ftrace_call+0x5/0x34 + tcpa_statistic_send+0x5/0x130 [ttcp_engine] + +The tcpa_statistic_send is the function being kprobed. After analysis, +the root cause is that the fourth parameter regs of kprobe_ftrace_handler +is NULL. Why regs is NULL? We use the crash tool to analyze the kdump. + + crash> dis tcpa_statistic_send -r + : callq 0xffffffffbd8018c0 + +The tcpa_statistic_send calls ftrace_caller instead of ftrace_regs_caller. +So it is reasonable that the fourth parameter regs of kprobe_ftrace_handler +is NULL. In theory, we should call the ftrace_regs_caller instead of the +ftrace_caller. After in-depth analysis, we found a reproducible path. + + Writing a simple kernel module which starts a periodic timer. The + timer's handler is named 'kprobe_test_timer_handler'. The module + name is kprobe_test.ko. + + 1) insmod kprobe_test.ko + 2) bpftrace -e 'kretprobe:kprobe_test_timer_handler {}' + 3) echo 0 > /proc/sys/kernel/ftrace_enabled + 4) rmmod kprobe_test + 5) stop step 2) kprobe + 6) insmod kprobe_test.ko + 7) bpftrace -e 'kretprobe:kprobe_test_timer_handler {}' + +We mark the kprobe as GONE but not disarm the kprobe in the step 4). +The step 5) also do not disarm the kprobe when unregister kprobe. So +we do not remove the ip from the filter. In this case, when the module +loads again in the step 6), we will replace the code to ftrace_caller +via the ftrace_module_enable(). When we register kprobe again, we will +not replace ftrace_caller to ftrace_regs_caller because the ftrace is +disabled in the step 3). So the step 7) will trigger kernel panic. Fix +this problem by disarming the kprobe when the module is going away. + +Link: https://lkml.kernel.org/r/20200728064536.24405-1-songmuchun@bytedance.com + +Cc: stable@vger.kernel.org +Fixes: ae6aa16fdc16 ("kprobes: introduce ftrace based optimization") +Acked-by: Masami Hiramatsu +Signed-off-by: Muchun Song +Co-developed-by: Chengming Zhou +Signed-off-by: Chengming Zhou +Signed-off-by: Steven Rostedt (VMware) +Signed-off-by: Greg Kroah-Hartman + +--- + kernel/kprobes.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +--- a/kernel/kprobes.c ++++ b/kernel/kprobes.c +@@ -2029,6 +2029,13 @@ static void kill_kprobe(struct kprobe *p + * the original probed function (which will be freed soon) any more. + */ + arch_remove_kprobe(p); ++ ++ /* ++ * The module is going away. We should disarm the kprobe which ++ * is using ftrace. ++ */ ++ if (kprobe_ftrace(p)) ++ disarm_kprobe_ftrace(p); + } + + /* Disable one kprobe */ diff --git a/queue-4.9/mac80211-fix-misplaced-while-instead-of-if.patch b/queue-4.9/mac80211-fix-misplaced-while-instead-of-if.patch new file mode 100644 index 00000000000..53a94fa7d81 --- /dev/null +++ b/queue-4.9/mac80211-fix-misplaced-while-instead-of-if.patch @@ -0,0 +1,37 @@ +From 5981fe5b0529ba25d95f37d7faa434183ad618c5 Mon Sep 17 00:00:00 2001 +From: Johannes Berg +Date: Mon, 3 Aug 2020 11:02:10 +0200 +Subject: mac80211: fix misplaced while instead of if + +From: Johannes Berg + +commit 5981fe5b0529ba25d95f37d7faa434183ad618c5 upstream. + +This never was intended to be a 'while' loop, it should've +just been an 'if' instead of 'while'. Fix this. + +I noticed this while applying another patch from Ben that +intended to fix a busy loop at this spot. + +Cc: stable@vger.kernel.org +Fixes: b16798f5b907 ("mac80211: mark station unauthorized before key removal") +Reported-by: Ben Greear +Link: https://lore.kernel.org/r/20200803110209.253009ae41ff.I3522aad099392b31d5cf2dcca34cbac7e5832dde@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Greg Kroah-Hartman + +--- + net/mac80211/sta_info.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/mac80211/sta_info.c ++++ b/net/mac80211/sta_info.c +@@ -946,7 +946,7 @@ static void __sta_info_destroy_part2(str + might_sleep(); + lockdep_assert_held(&local->sta_mtx); + +- while (sta->sta_state == IEEE80211_STA_AUTHORIZED) { ++ if (sta->sta_state == IEEE80211_STA_AUTHORIZED) { + ret = sta_info_move_state(sta, IEEE80211_STA_ASSOC); + WARN_ON_ONCE(ret); + } diff --git a/queue-4.9/md-raid5-fix-force-reconstruct-write-io-stuck-in-degraded-raid5.patch b/queue-4.9/md-raid5-fix-force-reconstruct-write-io-stuck-in-degraded-raid5.patch new file mode 100644 index 00000000000..4cd1cb087a0 --- /dev/null +++ b/queue-4.9/md-raid5-fix-force-reconstruct-write-io-stuck-in-degraded-raid5.patch @@ -0,0 +1,55 @@ +From a1c6ae3d9f3dd6aa5981a332a6f700cf1c25edef Mon Sep 17 00:00:00 2001 +From: ChangSyun Peng +Date: Fri, 31 Jul 2020 17:50:17 +0800 +Subject: md/raid5: Fix Force reconstruct-write io stuck in degraded raid5 + +From: ChangSyun Peng + +commit a1c6ae3d9f3dd6aa5981a332a6f700cf1c25edef upstream. + +In degraded raid5, we need to read parity to do reconstruct-write when +data disks fail. However, we can not read parity from +handle_stripe_dirtying() in force reconstruct-write mode. + +Reproducible Steps: + +1. Create degraded raid5 +mdadm -C /dev/md2 --assume-clean -l5 -n3 /dev/sda2 /dev/sdb2 missing +2. Set rmw_level to 0 +echo 0 > /sys/block/md2/md/rmw_level +3. IO to raid5 + +Now some io may be stuck in raid5. We can use handle_stripe_fill() to read +the parity in this situation. + +Cc: # v4.4+ +Reviewed-by: Alex Wu +Reviewed-by: BingJing Chang +Reviewed-by: Danny Shih +Signed-off-by: ChangSyun Peng +Signed-off-by: Song Liu +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/md/raid5.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/drivers/md/raid5.c ++++ b/drivers/md/raid5.c +@@ -3364,6 +3364,7 @@ static int need_this_block(struct stripe + * is missing/faulty, then we need to read everything we can. + */ + if (sh->raid_conf->level != 6 && ++ sh->raid_conf->rmw_level != PARITY_DISABLE_RMW && + sh->sector < sh->raid_conf->mddev->recovery_cp) + /* reconstruct-write isn't being forced */ + return 0; +@@ -4498,7 +4499,7 @@ static void handle_stripe(struct stripe_ + * or to load a block that is being partially written. + */ + if (s.to_read || s.non_overwrite +- || (conf->level == 6 && s.to_write && s.failed) ++ || (s.to_write && s.failed) + || (s.syncing && (s.uptodate + s.compute < disks)) + || s.replacing + || s.expanding) diff --git a/queue-4.9/mips-cpu-0-is-not-hotpluggable.patch b/queue-4.9/mips-cpu-0-is-not-hotpluggable.patch new file mode 100644 index 00000000000..a982e98d48a --- /dev/null +++ b/queue-4.9/mips-cpu-0-is-not-hotpluggable.patch @@ -0,0 +1,32 @@ +From 9cce844abf07b683cff5f0273977d5f8d0af94c7 Mon Sep 17 00:00:00 2001 +From: Huacai Chen +Date: Thu, 16 Jul 2020 18:40:23 +0800 +Subject: MIPS: CPU#0 is not hotpluggable + +From: Huacai Chen + +commit 9cce844abf07b683cff5f0273977d5f8d0af94c7 upstream. + +Now CPU#0 is not hotpluggable on MIPS, so prevent to create /sys/devices +/system/cpu/cpu0/online which confuses some user-space tools. + +Cc: stable@vger.kernel.org +Signed-off-by: Huacai Chen +Signed-off-by: Thomas Bogendoerfer +Signed-off-by: Greg Kroah-Hartman + +--- + arch/mips/kernel/topology.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/arch/mips/kernel/topology.c ++++ b/arch/mips/kernel/topology.c +@@ -19,7 +19,7 @@ static int __init topology_init(void) + for_each_present_cpu(i) { + struct cpu *c = &per_cpu(cpu_devices, i); + +- c->hotpluggable = 1; ++ c->hotpluggable = !!i; + ret = register_cpu(c, i); + if (ret) + printk(KERN_WARNING "topology_init: register_cpu %d " diff --git a/queue-4.9/net-compat-add-missing-sock-updates-for-scm_rights.patch b/queue-4.9/net-compat-add-missing-sock-updates-for-scm_rights.patch new file mode 100644 index 00000000000..49a9b2cb2cb --- /dev/null +++ b/queue-4.9/net-compat-add-missing-sock-updates-for-scm_rights.patch @@ -0,0 +1,89 @@ +From d9539752d23283db4692384a634034f451261e29 Mon Sep 17 00:00:00 2001 +From: Kees Cook +Date: Tue, 9 Jun 2020 16:11:29 -0700 +Subject: net/compat: Add missing sock updates for SCM_RIGHTS + +From: Kees Cook + +commit d9539752d23283db4692384a634034f451261e29 upstream. + +Add missed sock updates to compat path via a new helper, which will be +used more in coming patches. (The net/core/scm.c code is left as-is here +to assist with -stable backports for the compat path.) + +Cc: Christoph Hellwig +Cc: Sargun Dhillon +Cc: Jakub Kicinski +Cc: stable@vger.kernel.org +Fixes: 48a87cc26c13 ("net: netprio: fd passed in SCM_RIGHTS datagram not set correctly") +Fixes: d84295067fc7 ("net: net_cls: fd passed in SCM_RIGHTS datagram not set correctly") +Acked-by: Christian Brauner +Signed-off-by: Kees Cook +Signed-off-by: Greg Kroah-Hartman + +--- + include/net/sock.h | 4 ++++ + net/compat.c | 1 + + net/core/sock.c | 21 +++++++++++++++++++++ + 3 files changed, 26 insertions(+) + +--- a/include/net/sock.h ++++ b/include/net/sock.h +@@ -784,6 +784,8 @@ static inline int sk_memalloc_socks(void + { + return static_key_false(&memalloc_socks); + } ++ ++void __receive_sock(struct file *file); + #else + + static inline int sk_memalloc_socks(void) +@@ -791,6 +793,8 @@ static inline int sk_memalloc_socks(void + return 0; + } + ++static inline void __receive_sock(struct file *file) ++{ } + #endif + + static inline gfp_t sk_gfp_mask(const struct sock *sk, gfp_t gfp_mask) +--- a/net/compat.c ++++ b/net/compat.c +@@ -284,6 +284,7 @@ void scm_detach_fds_compat(struct msghdr + break; + } + /* Bump the usage count and install the file. */ ++ __receive_sock(fp[i]); + fd_install(new_fd, get_file(fp[i])); + } + +--- a/net/core/sock.c ++++ b/net/core/sock.c +@@ -2323,6 +2323,27 @@ int sock_no_mmap(struct file *file, stru + } + EXPORT_SYMBOL(sock_no_mmap); + ++/* ++ * When a file is received (via SCM_RIGHTS, etc), we must bump the ++ * various sock-based usage counts. ++ */ ++void __receive_sock(struct file *file) ++{ ++ struct socket *sock; ++ int error; ++ ++ /* ++ * The resulting value of "error" is ignored here since we only ++ * need to take action when the file is a socket and testing ++ * "sock" for NULL is sufficient. ++ */ ++ sock = sock_from_file(file, &error); ++ if (sock) { ++ sock_update_netprioidx(&sock->sk->sk_cgrp_data); ++ sock_update_classid(&sock->sk->sk_cgrp_data); ++ } ++} ++ + ssize_t sock_no_sendpage(struct socket *sock, struct page *page, int offset, size_t size, int flags) + { + ssize_t res; diff --git a/queue-4.9/net-ethernet-stmmac-disable-hardware-multicast-filter.patch b/queue-4.9/net-ethernet-stmmac-disable-hardware-multicast-filter.patch new file mode 100644 index 00000000000..84fd1c4441c --- /dev/null +++ b/queue-4.9/net-ethernet-stmmac-disable-hardware-multicast-filter.patch @@ -0,0 +1,39 @@ +From df43dd526e6609769ae513a81443c7aa727c8ca3 Mon Sep 17 00:00:00 2001 +From: Jonathan McDowell +Date: Wed, 12 Aug 2020 20:37:23 +0100 +Subject: net: ethernet: stmmac: Disable hardware multicast filter + +From: Jonathan McDowell + +commit df43dd526e6609769ae513a81443c7aa727c8ca3 upstream. + +The IPQ806x does not appear to have a functional multicast ethernet +address filter. This was observed as a failure to correctly receive IPv6 +packets on a LAN to the all stations address. Checking the vendor driver +shows that it does not attempt to enable the multicast filter and +instead falls back to receiving all multicast packets, internally +setting ALLMULTI. + +Use the new fallback support in the dwmac1000 driver to correctly +achieve the same with the mainline IPQ806x driver. Confirmed to fix IPv6 +functionality on an RB3011 router. + +Cc: stable@vger.kernel.org +Signed-off-by: Jonathan McDowell +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c ++++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +@@ -362,6 +362,7 @@ static int ipq806x_gmac_probe(struct pla + plat_dat->has_gmac = true; + plat_dat->bsp_priv = gmac; + plat_dat->fix_mac_speed = ipq806x_gmac_fix_mac_speed; ++ plat_dat->multicast_filter_bins = 0; + + err = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); + if (err) diff --git a/queue-4.9/net-stmmac-dwmac1000-provide-multicast-filter-fallback.patch b/queue-4.9/net-stmmac-dwmac1000-provide-multicast-filter-fallback.patch new file mode 100644 index 00000000000..2f17f6fae31 --- /dev/null +++ b/queue-4.9/net-stmmac-dwmac1000-provide-multicast-filter-fallback.patch @@ -0,0 +1,35 @@ +From 592d751c1e174df5ff219946908b005eb48934b3 Mon Sep 17 00:00:00 2001 +From: Jonathan McDowell +Date: Wed, 12 Aug 2020 20:37:01 +0100 +Subject: net: stmmac: dwmac1000: provide multicast filter fallback + +From: Jonathan McDowell + +commit 592d751c1e174df5ff219946908b005eb48934b3 upstream. + +If we don't have a hardware multicast filter available then instead of +silently failing to listen for the requested ethernet broadcast +addresses fall back to receiving all multicast packets, in a similar +fashion to other drivers with no multicast filter. + +Cc: stable@vger.kernel.org +Signed-off-by: Jonathan McDowell +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 +++ + 1 file changed, 3 insertions(+) + +--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c ++++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c +@@ -172,6 +172,9 @@ static void dwmac1000_set_filter(struct + value = GMAC_FRAME_FILTER_PR; + } else if (dev->flags & IFF_ALLMULTI) { + value = GMAC_FRAME_FILTER_PM; /* pass all multi */ ++ } else if (!netdev_mc_empty(dev) && (mcbitslog2 == 0)) { ++ /* Fall back to all multicast if we've no filter */ ++ value = GMAC_FRAME_FILTER_PM; + } else if (!netdev_mc_empty(dev)) { + struct netdev_hw_addr *ha; + diff --git a/queue-4.9/ocfs2-change-slot-number-type-s16-to-u16.patch b/queue-4.9/ocfs2-change-slot-number-type-s16-to-u16.patch new file mode 100644 index 00000000000..dc7c872cbda --- /dev/null +++ b/queue-4.9/ocfs2-change-slot-number-type-s16-to-u16.patch @@ -0,0 +1,87 @@ +From 38d51b2dd171ad973afc1f5faab825ed05a2d5e9 Mon Sep 17 00:00:00 2001 +From: Junxiao Bi +Date: Thu, 6 Aug 2020 23:18:02 -0700 +Subject: ocfs2: change slot number type s16 to u16 + +From: Junxiao Bi + +commit 38d51b2dd171ad973afc1f5faab825ed05a2d5e9 upstream. + +Dan Carpenter reported the following static checker warning. + + fs/ocfs2/super.c:1269 ocfs2_parse_options() warn: '(-1)' 65535 can't fit into 32767 'mopt->slot' + fs/ocfs2/suballoc.c:859 ocfs2_init_inode_steal_slot() warn: '(-1)' 65535 can't fit into 32767 'osb->s_inode_steal_slot' + fs/ocfs2/suballoc.c:867 ocfs2_init_meta_steal_slot() warn: '(-1)' 65535 can't fit into 32767 'osb->s_meta_steal_slot' + +That's because OCFS2_INVALID_SLOT is (u16)-1. Slot number in ocfs2 can be +never negative, so change s16 to u16. + +Fixes: 9277f8334ffc ("ocfs2: fix value of OCFS2_INVALID_SLOT") +Reported-by: Dan Carpenter +Signed-off-by: Junxiao Bi +Signed-off-by: Andrew Morton +Reviewed-by: Joseph Qi +Reviewed-by: Gang He +Cc: Mark Fasheh +Cc: Joel Becker +Cc: Junxiao Bi +Cc: Changwei Ge +Cc: Jun Piao +Cc: +Link: http://lkml.kernel.org/r/20200627001259.19757-1-junxiao.bi@oracle.com +Signed-off-by: Linus Torvalds +Signed-off-by: Greg Kroah-Hartman + +--- + fs/ocfs2/ocfs2.h | 4 ++-- + fs/ocfs2/suballoc.c | 4 ++-- + fs/ocfs2/super.c | 4 ++-- + 3 files changed, 6 insertions(+), 6 deletions(-) + +--- a/fs/ocfs2/ocfs2.h ++++ b/fs/ocfs2/ocfs2.h +@@ -337,8 +337,8 @@ struct ocfs2_super + spinlock_t osb_lock; + u32 s_next_generation; + unsigned long osb_flags; +- s16 s_inode_steal_slot; +- s16 s_meta_steal_slot; ++ u16 s_inode_steal_slot; ++ u16 s_meta_steal_slot; + atomic_t s_num_inodes_stolen; + atomic_t s_num_meta_stolen; + +--- a/fs/ocfs2/suballoc.c ++++ b/fs/ocfs2/suballoc.c +@@ -895,9 +895,9 @@ static void __ocfs2_set_steal_slot(struc + { + spin_lock(&osb->osb_lock); + if (type == INODE_ALLOC_SYSTEM_INODE) +- osb->s_inode_steal_slot = slot; ++ osb->s_inode_steal_slot = (u16)slot; + else if (type == EXTENT_ALLOC_SYSTEM_INODE) +- osb->s_meta_steal_slot = slot; ++ osb->s_meta_steal_slot = (u16)slot; + spin_unlock(&osb->osb_lock); + } + +--- a/fs/ocfs2/super.c ++++ b/fs/ocfs2/super.c +@@ -91,7 +91,7 @@ struct mount_options + unsigned long commit_interval; + unsigned long mount_opt; + unsigned int atime_quantum; +- signed short slot; ++ unsigned short slot; + int localalloc_opt; + unsigned int resv_level; + int dir_resv_level; +@@ -1369,7 +1369,7 @@ static int ocfs2_parse_options(struct su + goto bail; + } + if (option) +- mopt->slot = (s16)option; ++ mopt->slot = (u16)option; + break; + case Opt_commit: + if (match_int(&args[0], &option)) { diff --git a/queue-4.9/pseries-fix-64-bit-logical-memory-block-panic.patch b/queue-4.9/pseries-fix-64-bit-logical-memory-block-panic.patch new file mode 100644 index 00000000000..4c9725ec79e --- /dev/null +++ b/queue-4.9/pseries-fix-64-bit-logical-memory-block-panic.patch @@ -0,0 +1,37 @@ +From 89c140bbaeee7a55ed0360a88f294ead2b95201b Mon Sep 17 00:00:00 2001 +From: Anton Blanchard +Date: Wed, 15 Jul 2020 10:08:20 +1000 +Subject: pseries: Fix 64 bit logical memory block panic + +From: Anton Blanchard + +commit 89c140bbaeee7a55ed0360a88f294ead2b95201b upstream. + +Booting with a 4GB LMB size causes us to panic: + + qemu-system-ppc64: OS terminated: OS panic: + Memory block size not suitable: 0x0 + +Fix pseries_memory_block_size() to handle 64 bit LMBs. + +Cc: stable@vger.kernel.org +Signed-off-by: Anton Blanchard +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20200715000820.1255764-1-anton@ozlabs.org +Signed-off-by: Greg Kroah-Hartman + +--- + arch/powerpc/platforms/pseries/hotplug-memory.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/arch/powerpc/platforms/pseries/hotplug-memory.c ++++ b/arch/powerpc/platforms/pseries/hotplug-memory.c +@@ -29,7 +29,7 @@ static bool rtas_hp_event; + unsigned long pseries_memory_block_size(void) + { + struct device_node *np; +- unsigned int memblock_size = MIN_MEMORY_BLOCK_SIZE; ++ u64 memblock_size = MIN_MEMORY_BLOCK_SIZE; + struct resource r; + + np = of_find_node_by_path("/ibm,dynamic-reconfiguration-memory"); diff --git a/queue-4.9/series b/queue-4.9/series index c88b2963822..05fd4c6869b 100644 --- a/queue-4.9/series +++ b/queue-4.9/series @@ -174,3 +174,18 @@ btrfs-fix-memory-leaks-after-failure-to-lookup-checksums-during-inode-logging.pa iio-dac-ad5592r-fix-unbalanced-mutex-unlocks-in-ad5592r_read_raw.patch xtensa-fix-xtensa_pmu_setup-prototype.patch powerpc-fix-circular-dependency-between-percpu.h-and-mmu.h.patch +net-ethernet-stmmac-disable-hardware-multicast-filter.patch +net-stmmac-dwmac1000-provide-multicast-filter-fallback.patch +net-compat-add-missing-sock-updates-for-scm_rights.patch +md-raid5-fix-force-reconstruct-write-io-stuck-in-degraded-raid5.patch +bcache-allocate-meta-data-pages-as-compound-pages.patch +mac80211-fix-misplaced-while-instead-of-if.patch +mips-cpu-0-is-not-hotpluggable.patch +ext2-fix-missing-percpu_counter_inc.patch +ocfs2-change-slot-number-type-s16-to-u16.patch +ftrace-setup-correct-ftrace_fl_regs-flags-for-module.patch +kprobes-fix-null-pointer-dereference-at-kprobe_ftrace_handler.patch +watchdog-f71808e_wdt-indicate-wdiof_cardreset-support-in-watchdog_info.options.patch +watchdog-f71808e_wdt-remove-use-of-wrong-watchdog_info-option.patch +watchdog-f71808e_wdt-clear-watchdog-timeout-occurred-flag.patch +pseries-fix-64-bit-logical-memory-block-panic.patch diff --git a/queue-4.9/watchdog-f71808e_wdt-clear-watchdog-timeout-occurred-flag.patch b/queue-4.9/watchdog-f71808e_wdt-clear-watchdog-timeout-occurred-flag.patch new file mode 100644 index 00000000000..29f7a3a7274 --- /dev/null +++ b/queue-4.9/watchdog-f71808e_wdt-clear-watchdog-timeout-occurred-flag.patch @@ -0,0 +1,51 @@ +From 4f39d575844148fbf3081571a1f3b4ae04150958 Mon Sep 17 00:00:00 2001 +From: Ahmad Fatoum +Date: Thu, 11 Jun 2020 21:17:45 +0200 +Subject: watchdog: f71808e_wdt: clear watchdog timeout occurred flag + +From: Ahmad Fatoum + +commit 4f39d575844148fbf3081571a1f3b4ae04150958 upstream. + +The flag indicating a watchdog timeout having occurred normally persists +till Power-On Reset of the Fintek Super I/O chip. The user can clear it +by writing a `1' to the bit. + +The driver doesn't offer a restart method, so regular system reboot +might not reset the Super I/O and if the watchdog isn't enabled, we +won't touch the register containing the bit on the next boot. +In this case all subsequent regular reboots will be wrongly flagged +by the driver as being caused by the watchdog. + +Fix this by having the flag cleared after read. This is also done by +other drivers like those for the i6300esb and mpc8xxx_wdt. + +Fixes: b97cb21a4634 ("watchdog: f71808e_wdt: Fix WDTMOUT_STS register read") +Cc: stable@vger.kernel.org +Signed-off-by: Ahmad Fatoum +Reviewed-by: Guenter Roeck +Link: https://lore.kernel.org/r/20200611191750.28096-5-a.fatoum@pengutronix.de +Signed-off-by: Guenter Roeck +Signed-off-by: Wim Van Sebroeck +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/watchdog/f71808e_wdt.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +--- a/drivers/watchdog/f71808e_wdt.c ++++ b/drivers/watchdog/f71808e_wdt.c +@@ -704,6 +704,13 @@ static int __init watchdog_init(int sioa + wdt_conf = superio_inb(sioaddr, F71808FG_REG_WDT_CONF); + watchdog.caused_reboot = wdt_conf & BIT(F71808FG_FLAG_WDTMOUT_STS); + ++ /* ++ * We don't want WDTMOUT_STS to stick around till regular reboot. ++ * Write 1 to the bit to clear it to zero. ++ */ ++ superio_outb(sioaddr, F71808FG_REG_WDT_CONF, ++ wdt_conf | BIT(F71808FG_FLAG_WDTMOUT_STS)); ++ + superio_exit(sioaddr); + + err = watchdog_set_timeout(timeout); diff --git a/queue-4.9/watchdog-f71808e_wdt-indicate-wdiof_cardreset-support-in-watchdog_info.options.patch b/queue-4.9/watchdog-f71808e_wdt-indicate-wdiof_cardreset-support-in-watchdog_info.options.patch new file mode 100644 index 00000000000..dfbbc962fa7 --- /dev/null +++ b/queue-4.9/watchdog-f71808e_wdt-indicate-wdiof_cardreset-support-in-watchdog_info.options.patch @@ -0,0 +1,38 @@ +From e871e93fb08a619dfc015974a05768ed6880fd82 Mon Sep 17 00:00:00 2001 +From: Ahmad Fatoum +Date: Thu, 11 Jun 2020 21:17:43 +0200 +Subject: watchdog: f71808e_wdt: indicate WDIOF_CARDRESET support in watchdog_info.options + +From: Ahmad Fatoum + +commit e871e93fb08a619dfc015974a05768ed6880fd82 upstream. + +The driver supports populating bootstatus with WDIOF_CARDRESET, but so +far userspace couldn't portably determine whether absence of this flag +meant no watchdog reset or no driver support. Or-in the bit to fix this. + +Fixes: b97cb21a4634 ("watchdog: f71808e_wdt: Fix WDTMOUT_STS register read") +Cc: stable@vger.kernel.org +Signed-off-by: Ahmad Fatoum +Reviewed-by: Guenter Roeck +Link: https://lore.kernel.org/r/20200611191750.28096-3-a.fatoum@pengutronix.de +Signed-off-by: Guenter Roeck +Signed-off-by: Wim Van Sebroeck +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/watchdog/f71808e_wdt.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/drivers/watchdog/f71808e_wdt.c ++++ b/drivers/watchdog/f71808e_wdt.c +@@ -690,7 +690,8 @@ static int __init watchdog_init(int sioa + watchdog.sioaddr = sioaddr; + watchdog.ident.options = WDIOC_SETTIMEOUT + | WDIOF_MAGICCLOSE +- | WDIOF_KEEPALIVEPING; ++ | WDIOF_KEEPALIVEPING ++ | WDIOF_CARDRESET; + + snprintf(watchdog.ident.identity, + sizeof(watchdog.ident.identity), "%s watchdog", diff --git a/queue-4.9/watchdog-f71808e_wdt-remove-use-of-wrong-watchdog_info-option.patch b/queue-4.9/watchdog-f71808e_wdt-remove-use-of-wrong-watchdog_info-option.patch new file mode 100644 index 00000000000..3ed8f0d4221 --- /dev/null +++ b/queue-4.9/watchdog-f71808e_wdt-remove-use-of-wrong-watchdog_info-option.patch @@ -0,0 +1,48 @@ +From 802141462d844f2e6a4d63a12260d79b7afc4c34 Mon Sep 17 00:00:00 2001 +From: Ahmad Fatoum +Date: Thu, 11 Jun 2020 21:17:44 +0200 +Subject: watchdog: f71808e_wdt: remove use of wrong watchdog_info option + +From: Ahmad Fatoum + +commit 802141462d844f2e6a4d63a12260d79b7afc4c34 upstream. + +The flags that should be or-ed into the watchdog_info.options by drivers +all start with WDIOF_, e.g. WDIOF_SETTIMEOUT, which indicates that the +driver's watchdog_ops has a usable set_timeout. + +WDIOC_SETTIMEOUT was used instead, which expands to 0xc0045706, which +equals: + + WDIOF_FANFAULT | WDIOF_EXTERN1 | WDIOF_PRETIMEOUT | WDIOF_ALARMONLY | + WDIOF_MAGICCLOSE | 0xc0045000 + +These were so far indicated to userspace on WDIOC_GETSUPPORT. +As the driver has not yet been migrated to the new watchdog kernel API, +the constant can just be dropped without substitute. + +Fixes: 96cb4eb019ce ("watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG") +Cc: stable@vger.kernel.org +Signed-off-by: Ahmad Fatoum +Reviewed-by: Guenter Roeck +Link: https://lore.kernel.org/r/20200611191750.28096-4-a.fatoum@pengutronix.de +Signed-off-by: Guenter Roeck +Signed-off-by: Wim Van Sebroeck +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/watchdog/f71808e_wdt.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +--- a/drivers/watchdog/f71808e_wdt.c ++++ b/drivers/watchdog/f71808e_wdt.c +@@ -688,8 +688,7 @@ static int __init watchdog_init(int sioa + * into the module have been registered yet. + */ + watchdog.sioaddr = sioaddr; +- watchdog.ident.options = WDIOC_SETTIMEOUT +- | WDIOF_MAGICCLOSE ++ watchdog.ident.options = WDIOF_MAGICCLOSE + | WDIOF_KEEPALIVEPING + | WDIOF_CARDRESET; +