From: drh <>
Date: Wed, 21 Sep 2022 09:54:41 +0000 (+0000)
Subject: The RIGHT JOIN logic added to version 3.39.0 added a new restriction on the
X-Git-Tag: version-3.40.0~198
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2897b88f9eac533b829230c18c40ef35abc7ae86;p=thirdparty%2Fsqlite.git

The RIGHT JOIN logic added to version 3.39.0 added a new restriction on the
query flattener which resulted in a performance regression for some queries,
as documented by [forum:/forumpost/96b9e5709cf47cda|forum post 96b9e5709cf47cda].
This change removes that restriction (thus restoring performance) and fixes the
problem that RIGHT JOIN was having in a different way.

FossilOrigin-Name: 501609eddf2a46d51e8cd56477a22d4df142a166e78fe4322c0db11d1eed6687
---

2897b88f9eac533b829230c18c40ef35abc7ae86
diff --cc manifest
index 987d96a26b,40c1bb24e9..7db55b50f8
--- a/manifest
+++ b/manifest
@@@ -1,5 -1,5 +1,5 @@@
- C Update\sthe\sfuzz\sinvariant\schecker\sto\sconform\sto\sthe\slatest\schanges\sin\ndbsqlfuzz.
- D 2022-09-20T17:21:54.866
 -C Break\sout\sthe\sdecision\sof\swhether\sor\snot\sa\sconstraint\sterm\sis\susable\sby\nan\souter\sjoin\sinto\sa\ssubroutine:\sconstraintCompatibleWithOuterJoin().
 -D 2022-09-21T00:16:59.294
++C The\sRIGHT\sJOIN\slogic\sadded\sto\sversion\s3.39.0\sadded\sa\snew\srestriction\son\sthe\nquery\sflattener\swhich\sresulted\sin\sa\sperformance\sregression\sfor\ssome\squeries,\nas\sdocumented\sby\s[forum:/forumpost/96b9e5709cf47cda|forum\spost\s96b9e5709cf47cda].\nThis\schange\sremoves\sthat\srestriction\s(thus\srestoring\sperformance)\sand\sfixes\sthe\nproblem\sthat\sRIGHT\sJOIN\swas\shaving\sin\sa\sdifferent\sway.
++D 2022-09-21T09:54:41.195
  F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
  F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
  F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@@ -2000,8 -2000,8 +2000,9 @@@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a9
  F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
  F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
  F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
- P 2647d73bb1876d01851f52cb3fd6af08a962ab336b6d51c160d27b1baf94f75f
- R 4c12344a007c9e9bdcdbf323756fa10a
 -P f47aa745690c018800243bf76930b2499ff4537411c4e27b4b16ba3854cc2bf8
++P 8d8c124349d2a25200ace9a60d76751594b722468ad0c39d927a5d2c6e2464e0 c7fbc9b0453050e2746af27e3a11e0c3701bef8c56da8e19173242c6ea3aff8b
+ R ffb250842cc4325c51d9fb2f2a7cd199
++T +closed c7fbc9b0453050e2746af27e3a11e0c3701bef8c56da8e19173242c6ea3aff8b
  U drh
- Z 7b99665ad0fc78591cd70e35a24e34f9
 -Z 35e62397d6a559d77545ee94797c3cd6
++Z c4277c5174933f302dd59d96a8e6bf4e
  # Remove this line to create a well-formed Fossil manifest.
diff --cc manifest.uuid
index 7ec8709a6f,dc64e5b341..c74cd3d3de
--- a/manifest.uuid
+++ b/manifest.uuid
@@@ -1,1 -1,1 +1,1 @@@
- 8d8c124349d2a25200ace9a60d76751594b722468ad0c39d927a5d2c6e2464e0
 -c7fbc9b0453050e2746af27e3a11e0c3701bef8c56da8e19173242c6ea3aff8b
++501609eddf2a46d51e8cd56477a22d4df142a166e78fe4322c0db11d1eed6687