From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Date: Fri, 9 Dec 2022 17:31:04 +0000 (+0100)
Subject: apparmor: properly check lxc_strmmap ret value
X-Git-Tag: lxc-5.0.2~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=28a1591cd5730442e4504e4022a2ac7d4ea48eb1;p=thirdparty%2Flxc.git

apparmor: properly check lxc_strmmap ret value

Reported-by: coverity (CID #1517320)
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
---

diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c
index bf0f771e2..23af021aa 100644
--- a/src/lxc/lsm/apparmor.c
+++ b/src/lxc/lsm/apparmor.c
@@ -975,7 +975,7 @@ static int load_apparmor_profile(struct lsm_ops *ops, struct lxc_conf *conf, con
 		old_len = profile_sb.st_size;
 		old_content = lxc_strmmap(NULL, old_len, PROT_READ,
 		                          MAP_PRIVATE, profile_fd, 0);
-		if (!old_content) {
+		if (old_content == MAP_FAILED) {
 			SYSERROR("Failed to mmap old profile from %s",
 			         profile_path);
 			goto out;