From: Amos Jeffries <squid3@treenet.co.nz>
Date: Tue, 8 Nov 2016 06:33:38 +0000 (+1300)
Subject: Make key= before cert= a fatal error instead of quietly hiding the issue
X-Git-Tag: SQUID_4_0_17~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=28e1d824b2709692b463f590f8e3fd4d6b944652;p=thirdparty%2Fsquid.git

Make key= before cert= a fatal error instead of quietly hiding the issue
---

diff --git a/src/security/PeerOptions.cc b/src/security/PeerOptions.cc
index 0e07706fb2..825a15759a 100644
--- a/src/security/PeerOptions.cc
+++ b/src/security/PeerOptions.cc
@@ -59,7 +59,7 @@ Security::PeerOptions::parse(const char *token)
         certs.emplace_back(t);
     } else if (strncmp(token, "key=", 4) == 0) {
         if (certs.empty() || certs.back().certFile.isEmpty()) {
-            debugs(3, DBG_PARSE_NOTE(1), "ERROR: cert= option must be set before key= is used.");
+            fatal("cert= option must be set before key= is used.");
             return;
         }
         KeyData &t = certs.back();