From: Paulo Alcantara <pc@manguebit.org>
Date: Sat, 26 Jul 2025 16:47:51 +0000 (-0300)
Subject: smb: client: get rid of kstrdup() when parsing iocharset mount option
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=28f09823de9292c6f91171f0627bd0b360b78a75;p=thirdparty%2Fkernel%2Flinux.git

smb: client: get rid of kstrdup() when parsing iocharset mount option

Steal string reference from @param->string rather than duplicating it.

Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index 8b7ad5bf3302b..3f34bb07997b9 100644
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1532,11 +1532,7 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
 
 		if (strncasecmp(param->string, "default", 7) != 0) {
 			kfree(ctx->iocharset);
-			ctx->iocharset = kstrdup(param->string, GFP_KERNEL);
-			if (ctx->iocharset == NULL) {
-				cifs_errorf(fc, "OOM when copying iocharset string\n");
-				goto cifs_parse_mount_err;
-			}
+			ctx->iocharset = no_free_ptr(param->string);
 		}
 		/* if iocharset not set then load_nls_default
 		 * is used by caller