From: Valentin Schneider Date: Fri, 1 Sep 2023 15:10:38 +0000 (+0200) Subject: tracing/filters: Change parse_pred() cpulist ternary into an if block X-Git-Tag: v6.6-rc1~79^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2900bcbee3899e900853be555665f126673141b7;p=thirdparty%2Fkernel%2Flinux.git tracing/filters: Change parse_pred() cpulist ternary into an if block Review comments noted that an if block would be clearer than a ternary, so swap it out. No change in behaviour intended Link: https://lkml.kernel.org/r/20230901151039.125186-4-vschneid@redhat.com Cc: Masami Hiramatsu Signed-off-by: Valentin Schneider Signed-off-by: Steven Rostedt (Google) --- diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index eb331e8b00b61..09b4733a2933d 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -1782,13 +1782,17 @@ static int parse_pred(const char *str, void *data, FILTER_PRED_FN_CPUMASK; } else if (field->filter_type == FILTER_CPU) { if (single) { - pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; + if (pred->op == OP_BAND) + pred->op = OP_EQ; + pred->fn_num = FILTER_PRED_FN_CPU; } else { pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; } } else if (single) { - pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; + if (pred->op == OP_BAND) + pred->op = OP_EQ; + pred->fn_num = select_comparison_fn(pred->op, field->size, false); if (pred->op == OP_NE) pred->not = 1;