From: Jan Tulak <jtulak@redhat.com>
Date: Tue, 21 Jun 2016 02:52:22 +0000 (+1000)
Subject: mkfs: fix -l su minval
X-Git-Tag: v4.7.0-rc1~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2942ff49bdb6df08fb56674215b31c07cfc7c1fd;p=thirdparty%2Fxfsprogs-dev.git

mkfs: fix -l su minval

-l su should be in range BBTOB(1) <= L_SU <= XLOG_MAX_RECORD_BSIZE,
because the upper limit is imposed by kernel on iclogbuf: stripe
unit can't be bigger than the log buffer, but the log buffer can
span multiple stripe units. L_SUNIT is changed in the same way.

Signed-off-by: Jan Tulak <jtulak@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 1593ee893..ce1ade257 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -452,7 +452,7 @@ struct opt_params lopts = {
 		{ .index = L_SUNIT,
 		  .conflicts = { L_SU,
 				 LAST_CONFLICT },
-		  .minval = BTOBB(XLOG_MIN_RECORD_BSIZE),
+		  .minval = 1,
 		  .maxval = BTOBB(XLOG_MAX_RECORD_BSIZE),
 		  .defaultval = SUBOPT_NEEDS_VAL,
 		},
@@ -460,7 +460,7 @@ struct opt_params lopts = {
 		  .conflicts = { L_SUNIT,
 				 LAST_CONFLICT },
 		  .convert = true,
-		  .minval = XLOG_MIN_RECORD_BSIZE,
+		  .minval = BBTOB(1),
 		  .maxval = XLOG_MAX_RECORD_BSIZE,
 		  .defaultval = SUBOPT_NEEDS_VAL,
 		},