From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 31 Oct 2023 11:10:59 +0000 (+0100)
Subject: target/i386/cpu: Improve error message for property "vendor"
X-Git-Tag: v8.2.0-rc1~12^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=298d8b122056052951bda487392d8aabbfd0f3e5;p=thirdparty%2Fqemu.git

target/i386/cpu: Improve error message for property "vendor"

Improve

    $ qemu-system-x86_64 -device max-x86_64-cpu,vendor=me
    qemu-system-x86_64: -device max-x86_64-cpu,vendor=me: Property '.vendor' doesn't take value 'me'

to

    qemu-system-x86_64: -device max-x86_64-cpu,vendor=0123456789abc: value of property 'vendor' must consist of exactly 12 characters

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-8-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[Typo corrected]
---

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 358d9c0a655..cd16cb893da 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5192,7 +5192,8 @@ static void x86_cpuid_set_vendor(Object *obj, const char *value,
     int i;
 
     if (strlen(value) != CPUID_VENDOR_SZ) {
-        error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value);
+        error_setg(errp, "value of property 'vendor' must consist of"
+                   " exactly " stringify(CPUID_VENDOR_SZ) " characters");
         return;
     }