From: Axel Viala <axel.viala@darnuria.eu>
Date: Thu, 6 Oct 2022 11:50:43 +0000 (+0200)
Subject: [clang-tidy:Ccast] Avoid a C cast and modernize.
X-Git-Tag: dnsdist-1.8.0-rc1~140^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=299912ccbd5eef206bb666b33489839ba0721e93;p=thirdparty%2Fpdns.git

[clang-tidy:Ccast] Avoid a C cast and modernize.

Code inspired by how it's done in test-dnsrecords_cc.cc.
---

diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index 19edfa42fa..9a2ee1a599 100644
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -114,7 +114,7 @@ shared_ptr<DNSRecordContent> DNSRecordContent::deserialize(const DNSName& qname,
     (void) pos;
   }
 
-  MOADNSParser mdp(false, (char*)&*packet.begin(), (unsigned int)packet.size());
+  MOADNSParser mdp(false, reinterpret_cast<const char *>(packet.data()), packet.size());
   shared_ptr<DNSRecordContent> ret= mdp.d_answers.begin()->first.d_content;
   return ret;
 }