From: Duoming Zhou Date: Mon, 1 Sep 2025 13:26:17 +0000 (+0800) Subject: media: TDA1997x: Remove redundant cancel_delayed_work in probe X-Git-Tag: v6.19-rc1~159^2~236 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=29de195ca39fc2ac0af6fd45522994df9f431f80;p=thirdparty%2Fkernel%2Flinux.git media: TDA1997x: Remove redundant cancel_delayed_work in probe The delayed_work delayed_work_enable_hpd is initialized with INIT_DELAYED_WORK(), but it is never scheduled in tda1997x_probe(). Calling cancel_delayed_work() on a work that has never been scheduled is redundant and unnecessary, as there is no pending work to cancel. Remove the redundant cancel_delayed_work() from error handling path in tda1997x_probe() to avoid potential confusion. Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver") Cc: stable@vger.kernel.org Signed-off-by: Duoming Zhou Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 1087d2bddaf29..3532766cd795d 100644 --- a/drivers/media/i2c/tda1997x.c +++ b/drivers/media/i2c/tda1997x.c @@ -2797,7 +2797,6 @@ err_free_media: err_free_handler: v4l2_ctrl_handler_free(&state->hdl); err_free_mutex: - cancel_delayed_work(&state->delayed_work_enable_hpd); mutex_destroy(&state->page_lock); mutex_destroy(&state->lock); tda1997x_set_power(state, 0);