From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Sun, 5 Mar 2017 18:45:04 +0000 (+0100)
Subject: lib-http: test-http-server-errors: Fixed logically dead code.
X-Git-Tag: 2.3.0.rc1~1969
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=29e074eeea9975be7cca658651ea5184de184fcc;p=thirdparty%2Fdovecot%2Fcore.git

lib-http: test-http-server-errors: Fixed logically dead code.

Problem reported by Coverity.
---

diff --git a/src/lib-http/test-http-server-errors.c b/src/lib-http/test-http-server-errors.c
index 5c595c0f98..2f26d59040 100644
--- a/src/lib-http/test-http-server-errors.c
+++ b/src/lib-http/test-http-server-errors.c
@@ -247,7 +247,7 @@ test_server_hanging_request_payload_input(struct _hanging_request_payload *ctx)
 
 	if (ret == 0)
 		return;
-	if (ret < 0) {
+	if (ctx->payload_input->stream_errno != 0) {
 		if (debug) {
 			i_debug("test server: failed to read payload: %s",
 				i_stream_get_error(ctx->payload_input));
@@ -259,6 +259,8 @@ test_server_hanging_request_payload_input(struct _hanging_request_payload *ctx)
 		http_server_request_unref(&req);
 		return;
 	}
+
+	i_assert(i_stream_is_eof(ctx->payload_input));
 		
 	resp = http_server_response_create(req, 200, "OK");
 	http_server_response_submit(resp);