From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 13 Mar 2024 22:01:18 +0000 (+0100)
Subject: virsh: snapshot: Make 'snapshotname' argument positional
X-Git-Tag: v10.3.0-rc1~122
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=29f3ac42235b88c1d018494523d76968617972f4;p=thirdparty%2Flibvirt.git

virsh: snapshot: Make 'snapshotname' argument positional

The 'snapshotname' argument is optional as by default "current" snapshot
is considered. Regardless of that we should treat it as positional as
it's the common usage. This is now possible as we can have one optional
positional argument.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index 638333f4d6..6c8194d67f 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -486,6 +486,7 @@ static const vshCmdOptDef opts_snapshot_edit[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT),
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("snapshot name"),
      .completer = virshSnapshotNameCompleter,
     },
@@ -599,6 +600,7 @@ static const vshCmdOptDef opts_snapshot_current[] = {
     },
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("name of existing snapshot to make current"),
      .completer = virshSnapshotNameCompleter,
     },
@@ -798,6 +800,7 @@ static const vshCmdOptDef opts_snapshot_info[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT),
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("snapshot name"),
      .completer = virshSnapshotNameCompleter,
     },
@@ -1635,6 +1638,7 @@ static const vshCmdOptDef opts_snapshot_parent[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT),
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("find parent of snapshot name"),
      .completer = virshSnapshotNameCompleter,
     },
@@ -1682,6 +1686,7 @@ static const vshCmdOptDef opts_snapshot_revert[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT),
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("snapshot name"),
      .completer = virshSnapshotNameCompleter,
     },
@@ -1763,6 +1768,7 @@ static const vshCmdOptDef opts_snapshot_delete[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_HAS_SNAPSHOT),
     {.name = "snapshotname",
      .type = VSH_OT_STRING,
+     .positional = true,
      .help = N_("snapshot name"),
      .completer = virshSnapshotNameCompleter,
     },