From: Nathan Chancellor Date: Fri, 18 Apr 2025 20:17:20 +0000 (-0400) Subject: gpio: Restrict GPIO_ICH to compile testing with HAS_IOPORT X-Git-Tag: v6.16-rc1~169^2~52 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=29f4c4da74acfbd54f5ad2dfafe1a8f93af00431;p=thirdparty%2Flinux.git gpio: Restrict GPIO_ICH to compile testing with HAS_IOPORT When building gpio-ich.c for a platform that does not have IO port access like s390, there are several errors due to the use of inl() and outl() throughout the driver: drivers/gpio/gpio-ich.c: In function 'ichx_read_bit': include/asm-generic/io.h:578:14: error: call to '_inl' declared with attribute error: inl() requires CONFIG_HAS_IOPORT Only allow compile testing when the targeted platform selects HAS_IOPORT so that there are no compile time errors. Fixes: f3592d252f77 ("gpio: ich: enable building with COMPILE_TEST=y") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202504171941.g1yXja0j-lkp@intel.com/ Signed-off-by: Nathan Chancellor Link: https://lore.kernel.org/r/20250418-gpio-ich-fix-build-without-ioport-v1-1-83fc753438ec@kernel.org Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index bbbb550cac934..13b7319162c89 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -380,7 +380,7 @@ config GPIO_HLWD config GPIO_ICH tristate "Intel ICH GPIO" - depends on (X86 && LPC_ICH) || COMPILE_TEST + depends on (X86 && LPC_ICH) || (COMPILE_TEST && HAS_IOPORT) help Say yes here to support the GPIO functionality of a number of Intel ICH-based chipsets. Currently supported devices: ICH6, ICH7, ICH8