From: Ido Schimmel Date: Tue, 30 Jul 2024 13:58:14 +0000 (+0200) Subject: mlxsw: core_thermal: Remove another unnecessary check X-Git-Tag: v6.12-rc1~232^2~349^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2a1c9dcb52ddc2916115e4a781f9f2a09c536d97;p=thirdparty%2Fkernel%2Flinux.git mlxsw: core_thermal: Remove another unnecessary check mlxsw_thermal_modules_init() allocates an array of modules and then initializes each entry by calling mlxsw_thermal_module_init() which among other things initializes the 'parent' pointer of the entry. mlxsw_thermal_modules_init() then traverses over the array again, but skips over entries that do not have their 'parent' pointer set which is impossible given the above. Therefore, remove the unnecessary check. Signed-off-by: Ido Schimmel Reviewed-by: Vadim Pasternak Signed-off-by: Petr Machata Reviewed-by: Wojciech Drewek Link: https://patch.msgid.link/fb3e8ded422a441436431d5785b900f11ffc9621.1722345311.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c index 394e4fd633ef2..afd8fe85a94db 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c @@ -505,8 +505,6 @@ mlxsw_thermal_modules_init(struct device *dev, struct mlxsw_core *core, for (i = 0; i < area->tz_module_num; i++) { module_tz = &area->tz_module_arr[i]; - if (!module_tz->parent) - continue; err = mlxsw_thermal_module_tz_init(module_tz); if (err) goto err_thermal_module_tz_init;