From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 12 Apr 2021 19:32:34 +0000 (+0000)
Subject: refs: print errno for read_raw_ref if GIT_TRACE_REFS is set
X-Git-Tag: v2.32.0-rc0~56^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2a2112a42913ee7397f950f3b8f9b3f3ab84a631;p=thirdparty%2Fgit.git

refs: print errno for read_raw_ref if GIT_TRACE_REFS is set

The ref backend API uses errno as a sideband error channel.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs/debug.c b/refs/debug.c
index 922e64fa6a..576bf98e74 100644
--- a/refs/debug.c
+++ b/refs/debug.c
@@ -244,6 +244,7 @@ static int debug_read_raw_ref(struct ref_store *ref_store, const char *refname,
 	int res = 0;
 
 	oidcpy(oid, &null_oid);
+	errno = 0;
 	res = drefs->refs->be->read_raw_ref(drefs->refs, refname, oid, referent,
 					    type);
 
@@ -251,7 +252,9 @@ static int debug_read_raw_ref(struct ref_store *ref_store, const char *refname,
 		trace_printf_key(&trace_refs, "read_raw_ref: %s: %s (=> %s) type %x: %d\n",
 			refname, oid_to_hex(oid), referent->buf, *type, res);
 	} else {
-		trace_printf_key(&trace_refs, "read_raw_ref: %s: %d\n", refname, res);
+		trace_printf_key(&trace_refs,
+				 "read_raw_ref: %s: %d (errno %d)\n", refname,
+				 res, errno);
 	}
 	return res;
 }