From: Willy Tarreau <w@1wt.eu>
Date: Sun, 5 Nov 2017 08:58:01 +0000 (+0100)
Subject: BUG/MAJOR: threads/server: missing unlock in CLI fqdn parser
X-Git-Tag: v1.8-rc3~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2a858a82ec874cca679a0938b103c6cf6329c17a;p=thirdparty%2Fhaproxy.git

BUG/MAJOR: threads/server: missing unlock in CLI fqdn parser

This one didn't properly unlock before returning an error message.
---

diff --git a/src/server.c b/src/server.c
index 555d6da19d..c96b096e2b 100644
--- a/src/server.c
+++ b/src/server.c
@@ -4202,6 +4202,7 @@ static int cli_parse_set_server(char **args, struct appctx *appctx, void *privat
 		if (!*args[4]) {
 			appctx->ctx.cli.msg = "set server <b>/<s> fqdn requires a FQDN.\n";
 			appctx->st0 = CLI_ST_PRINT;
+			SPIN_UNLOCK(SERVER_LOCK, &sv->lock);
 			return 1;
 		}
 		warning = update_server_fqdn(sv, args[4], "stats socket command", 0);