From: Philippe Mathieu-Daudé Date: Thu, 19 Jan 2023 12:05:14 +0000 (+0100) Subject: tests/qtest/vnc-display-test: Disable on Darwin X-Git-Tag: v8.0.0-rc0~81^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2a969c0cbcf575a4c839d60e6ed71bbb9e469fbe;p=thirdparty%2Fqemu.git tests/qtest/vnc-display-test: Disable on Darwin This test is failing in gtk-vnc on Darwin: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses the ucontext coroutine backend, which might be broken on Darwin. Disable this test (current problem being investigated in this thread: https://lore.kernel.org/qemu-devel/Y8kw6X6keB5l53nl@redhat.com/). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230119120514.28778-4-philmd@linaro.org> Reviewed-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau Signed-off-by: Thomas Huth --- diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c index df468c7b229..e52a4326ec9 100644 --- a/tests/qtest/vnc-display-test.c +++ b/tests/qtest/vnc-display-test.c @@ -19,7 +19,7 @@ typedef struct Test { GMainLoop *loop; } Test; -#if !defined(WIN32) +#if !defined(WIN32) && !defined(CONFIG_DARWIN) static void on_vnc_error(VncConnection* self, const char* msg) @@ -41,6 +41,9 @@ test_setup(Test *test) #ifdef WIN32 g_test_skip("Not supported on Windows yet"); return false; +#elif defined(CONFIG_DARWIN) + g_test_skip("Broken on Darwin"); + return false; #else int pair[2];