From: Qianfeng Rong Date: Thu, 21 Aug 2025 07:22:09 +0000 (+0800) Subject: RDMA/erdma: Use vcalloc() instead of vzalloc() X-Git-Tag: v6.18-rc1~102^2~72 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2aa35b24ad12fb960d30e9e282f768e1a0af9291;p=thirdparty%2Fkernel%2Fstable.git RDMA/erdma: Use vcalloc() instead of vzalloc() Replace vzalloc() with vcalloc() in vmalloc_to_dma_addrs(). As noted in the kernel documentation [1], open-coded multiplication in allocator arguments is discouraged because it can lead to integer overflow. Use vcalloc() to gain built-in overflow protection, making memory allocation safer when calculating allocation size compared to explicit multiplication. [1]: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Link: https://patch.msgid.link/r/20250821072209.510348-1-rongqianfeng@vivo.com Signed-off-by: Qianfeng Rong Reviewed-by: Cheng Xu Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c index b4dadd3068379..bb8809ed2f75b 100644 --- a/drivers/infiniband/hw/erdma/erdma_verbs.c +++ b/drivers/infiniband/hw/erdma/erdma_verbs.c @@ -671,7 +671,7 @@ static u32 vmalloc_to_dma_addrs(struct erdma_dev *dev, dma_addr_t **dma_addrs, npages = (PAGE_ALIGN((u64)buf + len) - PAGE_ALIGN_DOWN((u64)buf)) >> PAGE_SHIFT; - pg_dma = vzalloc(npages * sizeof(dma_addr_t)); + pg_dma = vcalloc(npages, sizeof(*pg_dma)); if (!pg_dma) return 0;