From: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Thu, 28 Apr 2011 11:58:30 +0000 (+0200)
Subject: qemu-progress.c: printf isn't signal safe
X-Git-Tag: v0.15.0-rc0~307
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2ab3cb8c0ae79c96f38f6bfd35620cc18ddba19f;p=thirdparty%2Fqemu.git

qemu-progress.c: printf isn't signal safe

Change the signal handling to indicate a signal is pending, rather
then printing directly from the signal handler.

In addition make the signal prints go to stderr, rather than stdout.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/qemu-progress.c b/qemu-progress.c
index e1feb896147..a4894c0dfc5 100644
--- a/qemu-progress.c
+++ b/qemu-progress.c
@@ -37,6 +37,7 @@ struct progress_state {
 };
 
 static struct progress_state state;
+static volatile sig_atomic_t print_pending;
 
 /*
  * Simple progress print function.
@@ -63,12 +64,16 @@ static void progress_simple_init(void)
 #ifdef CONFIG_POSIX
 static void sigusr_print(int signal)
 {
-    printf("    (%3.2f/100%%)\n", state.current);
+    print_pending = 1;
 }
 #endif
 
 static void progress_dummy_print(void)
 {
+    if (print_pending) {
+        fprintf(stderr, "    (%3.2f/100%%)\n", state.current);
+        print_pending = 0;
+    }
 }
 
 static void progress_dummy_end(void)