From: Geert Uytterhoeven Date: Thu, 7 Jun 2018 13:10:30 +0000 (+0200) Subject: net: mscc: ocelot: Fix uninitialized error in ocelot_netdevice_event() X-Git-Tag: v4.18-rc1~63^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2ac0e1524d9585f5261cebecca262da6cedc1d85;p=thirdparty%2Flinux.git net: mscc: ocelot: Fix uninitialized error in ocelot_netdevice_event() With gcc-4.1.2: drivers/net/ethernet/mscc/ocelot.c: In function ‘ocelot_netdevice_event’: drivers/net/ethernet/mscc/ocelot.c:1129: warning: ‘ret’ may be used uninitialized in this function If the list iterated over by netdev_for_each_lower_dev() is empty, ret is never initialized, and converted into a notifier return value. Fix this by preinitializing ret to zero. Fixes: a556c76adc052c97 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Geert Uytterhoeven Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index c8c74aa548d96..fb2c8f8071e64 100644 --- a/drivers/net/ethernet/mscc/ocelot.c +++ b/drivers/net/ethernet/mscc/ocelot.c @@ -1126,7 +1126,7 @@ static int ocelot_netdevice_event(struct notifier_block *unused, { struct netdev_notifier_changeupper_info *info = ptr; struct net_device *dev = netdev_notifier_info_to_dev(ptr); - int ret; + int ret = 0; if (netif_is_lag_master(dev)) { struct net_device *slave;