From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 13 Feb 2024 16:09:20 +0000 (+0100)
Subject: expression: missing line in describe command with invalid expression
X-Git-Tag: v1.1.0~100
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2b24dd29c5fa1c7e4cf44f0753752d25106273a0;p=thirdparty%2Fnftables.git

expression: missing line in describe command with invalid expression

Before:

 duh@testbed:~# nft describe blah
 symbol expression, datatype invalid (invalid)duh@testbed:#

After:

 duh@testbed:~# nft describe blah
 symbol expression, datatype invalid (invalid)
 duh@testbed:#

Fixes: 48aca2de80a7 ("iptopt: fix crash with invalid field/type combo")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/expression.c b/src/expression.c
index dde48b6a..cb2573fe 100644
--- a/src/expression.c
+++ b/src/expression.c
@@ -140,8 +140,10 @@ void expr_describe(const struct expr *expr, struct output_ctx *octx)
 		nft_print(octx, "%s expression, datatype %s (%s)",
 			  expr_name(expr), dtype->name, dtype->desc);
 
-		if (dtype == &invalid_type)
+		if (dtype == &invalid_type) {
+			nft_print(octx, "\n");
 			return;
+		}
 	}
 
 	if (dtype->basetype != NULL) {