From: Kevin Wolf <kwolf@redhat.com>
Date: Wed, 26 Oct 2011 09:03:01 +0000 (+0200)
Subject: block: Fix bdrv_open use after free
X-Git-Tag: v1.0-rc0~30^2~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2b5728164fcf5211bbae8d3c2fc6df62dd6b2295;p=thirdparty%2Fqemu.git

block: Fix bdrv_open use after free

tmp_filename was used outside the block it was defined in, i.e. after it went
out of scope. Move its declaration to the top level.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/block.c b/block.c
index f86984fd62a..d5ec0beaf01 100644
--- a/block.c
+++ b/block.c
@@ -571,6 +571,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
               BlockDriver *drv)
 {
     int ret;
+    char tmp_filename[PATH_MAX];
 
     if (flags & BDRV_O_SNAPSHOT) {
         BlockDriverState *bs1;
@@ -578,7 +579,6 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
         int is_protocol = 0;
         BlockDriver *bdrv_qcow2;
         QEMUOptionParameter *options;
-        char tmp_filename[PATH_MAX];
         char backing_filename[PATH_MAX];
 
         /* if snapshot, we create a temporary backing file and open it