From: Yuan Can <yuancan@huawei.com>
Date: Thu, 24 Nov 2022 03:19:26 +0000 (+0000)
Subject: tpm/tpm_ftpm_tee: Fix error handling in ftpm_mod_init()
X-Git-Tag: v6.2-rc1~211^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2b7d07f7acaac2c7750e420dcf4414588ede6d03;p=thirdparty%2Fkernel%2Flinux.git

tpm/tpm_ftpm_tee: Fix error handling in ftpm_mod_init()

The ftpm_mod_init() returns the driver_register() directly without checking
its return value, if driver_register() failed, the ftpm_tee_plat_driver is
not unregistered.

Fix by unregister ftpm_tee_plat_driver when driver_register() failed.

Fixes: 9f1944c23c8c ("tpm_ftpm_tee: register driver on TEE bus")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---

diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
index 5c233423c56fa..deff23bb54bf1 100644
--- a/drivers/char/tpm/tpm_ftpm_tee.c
+++ b/drivers/char/tpm/tpm_ftpm_tee.c
@@ -397,7 +397,13 @@ static int __init ftpm_mod_init(void)
 	if (rc)
 		return rc;
 
-	return driver_register(&ftpm_tee_driver.driver);
+	rc = driver_register(&ftpm_tee_driver.driver);
+	if (rc) {
+		platform_driver_unregister(&ftpm_tee_plat_driver);
+		return rc;
+	}
+
+	return 0;
 }
 
 static void __exit ftpm_mod_exit(void)