From: Eli Schwartz <eschwartz@gentoo.org>
Date: Fri, 25 Apr 2025 05:25:44 +0000 (-0400)
Subject: meson: fix typo in function check that prevented checking for hstrerror
X-Git-Tag: v2.50.0-rc0~63^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2b83df36f4176edb2457c5eb83f7adae990f2df4;p=thirdparty%2Fgit.git

meson: fix typo in function check that prevented checking for hstrerror

Nowhere in the codebase do we otherwise check for strerror. Nowhere in
the codebase do we make use of -DNO_STRERROR. `strerror` is not a
networking function at all.

We do utilize `hstrerror` though, which is a networking function we
should have been checking here.

Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/meson.build b/meson.build
index 66b69f2471..25bac8d89f 100644
--- a/meson.build
+++ b/meson.build
@@ -1088,7 +1088,7 @@ else
 endif
 libgit_dependencies += networking_dependencies
 
-foreach symbol : ['inet_ntop', 'inet_pton', 'strerror']
+foreach symbol : ['inet_ntop', 'inet_pton', 'hstrerror']
   if not compiler.has_function(symbol, dependencies: networking_dependencies)
     libgit_c_args += '-DNO_' + symbol.to_upper()
   endif