From: Frederic Lecaille <flecaille@haproxy.com>
Date: Thu, 12 Dec 2024 10:44:10 +0000 (+0100)
Subject: BUG/MINOR: quic: wrong bbr_target_inflight() implementation
X-Git-Tag: v3.2-dev2~87
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2bcd5b4cba4e9f123860560de0807312b909b306;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: wrong bbr_target_inflight() implementation

This bug arrived with this commit:

  6404b7a18a BUG/MINOR: quic: fix bbr_inflight() calls with wrong gain value

This patch partially reverts after having checked the BBR v3 draft.
This bug was invisible when testing long BBR flows.

Must be backported to 3.1.
---

diff --git a/src/quic_cc_bbr.c b/src/quic_cc_bbr.c
index a164c1f3f2..b08c4b5397 100644
--- a/src/quic_cc_bbr.c
+++ b/src/quic_cc_bbr.c
@@ -840,7 +840,7 @@ static void bbr_exit_probe_rtt(struct bbr *bbr)
 
 static uint64_t bbr_target_inflight(struct bbr *bbr, struct quic_cc_path *p)
 {
-	uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, bbr->cwnd_gain);
+	uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, 100);
 	return MIN(bdp, p->cwnd);
 }