From: Brian M. Carlson Date: Sat, 17 Aug 2013 17:25:42 +0000 (+0000) Subject: submodule: fix confusing variable name X-Git-Tag: v1.8.5-rc0~75^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2be945094ef753a47fa85d54dd472351f77c398c;p=thirdparty%2Fgit.git submodule: fix confusing variable name cmd_summary reads the output of git diff, but reads in the submodule path into a variable called name. Since this variable does not contain the name of the submodule, but the path, rename it to be clearer what data it actually holds. Signed-off-by: Brian M. Carlson Acked-by: Jens Lehmann Signed-off-by: Junio C Hamano --- diff --git a/git-submodule.sh b/git-submodule.sh index 2979197087..38520db7cc 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -1032,13 +1032,13 @@ cmd_summary() { # Get modified modules cared by user modules=$(git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- "$@" | sane_egrep '^:([0-7]* )?160000' | - while read mod_src mod_dst sha1_src sha1_dst status name + while read mod_src mod_dst sha1_src sha1_dst status sm_path do # Always show modules deleted or type-changed (blob<->module) - test $status = D -o $status = T && echo "$name" && continue + test $status = D -o $status = T && echo "$sm_path" && continue # Also show added or modified modules which are checked out - GIT_DIR="$name/.git" git-rev-parse --git-dir >/dev/null 2>&1 && - echo "$name" + GIT_DIR="$sm_path/.git" git-rev-parse --git-dir >/dev/null 2>&1 && + echo "$sm_path" done )