From: Hans de Goede Date: Thu, 4 Feb 2021 12:19:31 +0000 (+0100) Subject: platform/x86: msi-wmi: Fix variable 'status' set but not used compiler warning X-Git-Tag: v5.12-rc1~123^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2c15644ebed06949458bf6956ed124164ef51063;p=thirdparty%2Fkernel%2Flinux.git platform/x86: msi-wmi: Fix variable 'status' set but not used compiler warning Explicitly check the status rather then relying on output.pointer staying NULL on an error. Reported-by: Maximilian Luz Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20210204121931.131617-1-hdegoede@redhat.com --- diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c index 64ee7819c9d38..fd318cdfe313e 100644 --- a/drivers/platform/x86/msi-wmi.c +++ b/drivers/platform/x86/msi-wmi.c @@ -96,6 +96,8 @@ static int msi_wmi_query_block(int instance, int *ret) struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; status = wmi_query_block(MSIWMI_BIOS_GUID, instance, &output); + if (ACPI_FAILURE(status)) + return -EIO; obj = output.pointer;